Update Managed reconciler to store observedGeneration in conditions #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3wscott
commented
May 1, 2025
n3wscott
commented
May 1, 2025
n3wscott
changed the title
n3wscott
changed the title
negz
reviewed
May 2, 2025
n3wscott
force-pushed
the
managed-og
branch
2 times, most recently
from
ef25a7a to
17fce08
Compare
This was referenced May 2, 2025
n3wscott
force-pushed
the
managed-og
branch
3 times, most recently
from
eab2492 to
680888f
Compare
negz
approved these changes
May 9, 2025
Member
negz
left a comment
negz
left a comment
There was a problem hiding this comment.
I like the UX of this new API. Approving because the overall approach LGTM - I think you missed two spots in the reconciler that need updating though.
…nd also update that controllers unit tests Signed-off-by: Scott Nichols <[email protected]>
Signed-off-by: Scott Nichols <[email protected]>
Signed-off-by: Scott Nichols <[email protected]>
Signed-off-by: Scott Nichols <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update
Managedreconciler to store observedGeneration on conditions and also update that controllers unit tests.This uses the new
conditions.Managerto help propagate theobservedGenerationto the changed conditions within the reconciler.Relates to crossplane/crossplane#6420
Superseedes #789
Depends on #831
I have:
earthly +reviewableto ensure this PR is ready for review.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.