chore: sel tests

Author: adityachoudhari26

apps/workspace-engine/pkg/db/deployments_test.go

@@ -365,3 +365,296 @@ func TestDBDeployments_NonexistentSystemThrowsError(t *testing.T) {
 	// Keep workspaceID to avoid "declared but not used" error
 	_ = workspaceID
 }
+
+func TestDBDeployments_WithJsonResourceSelector(t *testing.T) {
+	workspaceID, conn := setupTestWithWorkspace(t)
+
+	tx, err := conn.Begin(t.Context())
+	if err != nil {
+		t.Fatalf("failed to begin tx: %v", err)
+	}
+	defer tx.Rollback(t.Context())
+
+	// Create a system first
+	systemID := uuid.New().String()
+	systemDescription := fmt.Sprintf("desc-%s", systemID[:8])
+	sys := &oapi.System{
+		Id:          systemID,
+		WorkspaceId: workspaceID,
+		Name:        fmt.Sprintf("test-system-%s", systemID[:8]),
+		Description: &systemDescription,
+	}
+	err = writeSystem(t.Context(), sys, tx)
+	if err != nil {
+		t.Fatalf("failed to create system: %v", err)
+	}
+
+	// Create deployment with JSON resource selector
+	deploymentID := uuid.New().String()
+	description := "test deployment with JSON selector"
+
+	// Create a JSON selector
+	resourceSelector := &oapi.Selector{}
+	err = resourceSelector.FromJsonSelector(oapi.JsonSelector{
+		Json: map[string]interface{}{
+			"type":     "name",
+			"operator": "equals",
+			"value":    "test-resource",
+		},
+	})
+	if err != nil {
+		t.Fatalf("failed to create JSON selector: %v", err)
+	}
+
+	deployment := &oapi.Deployment{
+		Id:               deploymentID,
+		Name:             fmt.Sprintf("test-deployment-%s", deploymentID[:8]),
+		Slug:             fmt.Sprintf("test-deployment-%s", deploymentID[:8]),
+		SystemId:         systemID,
+		Description:      &description,
+		JobAgentConfig:   map[string]interface{}{},
+		ResourceSelector: resourceSelector,
+	}
+
+	err = writeDeployment(t.Context(), deployment, tx)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	err = tx.Commit(t.Context())
+	if err != nil {
+		t.Fatalf("failed to commit: %v", err)
+	}
+
+	// Read back and validate
+	actualDeployments, err := getDeployments(t.Context(), workspaceID)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	if len(actualDeployments) != 1 {
+		t.Fatalf("expected 1 deployment, got %d", len(actualDeployments))
+	}
+
+	actualDeployment := actualDeployments[0]
+	if actualDeployment.ResourceSelector == nil {
+		t.Fatalf("expected resource selector to be non-nil")
+	}
+
+	// Validate the selector content
+	jsonSelector, err := actualDeployment.ResourceSelector.AsJsonSelector()
+	if err != nil {
+		t.Fatalf("expected JSON selector, got error: %v", err)
+	}
+
+	expectedJson := map[string]interface{}{
+		"type":     "name",
+		"operator": "equals",
+		"value":    "test-resource",
+	}
+
+	if jsonSelector.Json["type"] != expectedJson["type"] {
+		t.Fatalf("expected type %v, got %v", expectedJson["type"], jsonSelector.Json["type"])
+	}
+	if jsonSelector.Json["operator"] != expectedJson["operator"] {
+		t.Fatalf("expected operator %v, got %v", expectedJson["operator"], jsonSelector.Json["operator"])
+	}
+	if jsonSelector.Json["value"] != expectedJson["value"] {
+		t.Fatalf("expected value %v, got %v", expectedJson["value"], jsonSelector.Json["value"])
+	}
+}
+
+func TestDBDeployments_WithCelResourceSelector(t *testing.T) {
+	workspaceID, conn := setupTestWithWorkspace(t)
+
+	tx, err := conn.Begin(t.Context())
+	if err != nil {
+		t.Fatalf("failed to begin tx: %v", err)
+	}
+	defer tx.Rollback(t.Context())
+
+	// Create a system first
+	systemID := uuid.New().String()
+	systemDescription := fmt.Sprintf("desc-%s", systemID[:8])
+	sys := &oapi.System{
+		Id:          systemID,
+		WorkspaceId: workspaceID,
+		Name:        fmt.Sprintf("test-system-%s", systemID[:8]),
+		Description: &systemDescription,
+	}
+	err = writeSystem(t.Context(), sys, tx)
+	if err != nil {
+		t.Fatalf("failed to create system: %v", err)
+	}
+
+	// Create deployment with CEL resource selector
+	deploymentID := uuid.New().String()
+	description := "test deployment with CEL selector"
+
+	// Create a CEL selector
+	resourceSelector := &oapi.Selector{}
+	celExpression := "resource.metadata.environment == 'production'"
+	err = resourceSelector.FromCelSelector(oapi.CelSelector{
+		Cel: celExpression,
+	})
+	if err != nil {
+		t.Fatalf("failed to create CEL selector: %v", err)
+	}
+
+	deployment := &oapi.Deployment{
+		Id:               deploymentID,
+		Name:             fmt.Sprintf("test-deployment-%s", deploymentID[:8]),
+		Slug:             fmt.Sprintf("test-deployment-%s", deploymentID[:8]),
+		SystemId:         systemID,
+		Description:      &description,
+		JobAgentConfig:   map[string]interface{}{},
+		ResourceSelector: resourceSelector,
+	}
+
+	err = writeDeployment(t.Context(), deployment, tx)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	err = tx.Commit(t.Context())
+	if err != nil {
+		t.Fatalf("failed to commit: %v", err)
+	}
+
+	// Read back and validate
+	actualDeployments, err := getDeployments(t.Context(), workspaceID)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	if len(actualDeployments) != 1 {
+		t.Fatalf("expected 1 deployment, got %d", len(actualDeployments))
+	}
+
+	actualDeployment := actualDeployments[0]
+	if actualDeployment.ResourceSelector == nil {
+		t.Fatalf("expected resource selector to be non-nil")
+	}
+
+	// Validate the selector content
+	celSelector, err := actualDeployment.ResourceSelector.AsCelSelector()
+	if err != nil {
+		t.Fatalf("expected CEL selector, got error: %v", err)
+	}
+
+	if celSelector.Cel != celExpression {
+		t.Fatalf("expected CEL expression %s, got %s", celExpression, celSelector.Cel)
+	}
+}
+
+func TestDBDeployments_UpdateResourceSelector(t *testing.T) {
+	workspaceID, conn := setupTestWithWorkspace(t)
+
+	tx, err := conn.Begin(t.Context())
+	if err != nil {
+		t.Fatalf("failed to begin tx: %v", err)
+	}
+	defer tx.Rollback(t.Context())
+
+	// Create a system first
+	systemID := uuid.New().String()
+	systemDescription := fmt.Sprintf("desc-%s", systemID[:8])
+	sys := &oapi.System{
+		Id:          systemID,
+		WorkspaceId: workspaceID,
+		Name:        fmt.Sprintf("test-system-%s", systemID[:8]),
+		Description: &systemDescription,
+	}
+	err = writeSystem(t.Context(), sys, tx)
+	if err != nil {
+		t.Fatalf("failed to create system: %v", err)
+	}
+
+	// Create deployment with JSON selector
+	deploymentID := uuid.New().String()
+	description := "test deployment"
+
+	initialSelector := &oapi.Selector{}
+	err = initialSelector.FromJsonSelector(oapi.JsonSelector{
+		Json: map[string]interface{}{
+			"type":  "name",
+			"value": "initial",
+		},
+	})
+	if err != nil {
+		t.Fatalf("failed to create initial JSON selector: %v", err)
+	}
+
+	deployment := &oapi.Deployment{
+		Id:               deploymentID,
+		Name:             fmt.Sprintf("test-deployment-%s", deploymentID[:8]),
+		Slug:             fmt.Sprintf("test-deployment-%s", deploymentID[:8]),
+		SystemId:         systemID,
+		Description:      &description,
+		JobAgentConfig:   map[string]interface{}{},
+		ResourceSelector: initialSelector,
+	}
+
+	err = writeDeployment(t.Context(), deployment, tx)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	err = tx.Commit(t.Context())
+	if err != nil {
+		t.Fatalf("failed to commit: %v", err)
+	}
+
+	// Update with CEL selector
+	tx, err = conn.Begin(t.Context())
+	if err != nil {
+		t.Fatalf("failed to begin tx: %v", err)
+	}
+	defer tx.Rollback(t.Context())
+
+	updatedSelector := &oapi.Selector{}
+	celExpression := "resource.kind == 'pod'"
+	err = updatedSelector.FromCelSelector(oapi.CelSelector{
+		Cel: celExpression,
+	})
+	if err != nil {
+		t.Fatalf("failed to create CEL selector: %v", err)
+	}
+
+	deployment.ResourceSelector = updatedSelector
+
+	err = writeDeployment(t.Context(), deployment, tx)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	err = tx.Commit(t.Context())
+	if err != nil {
+		t.Fatalf("failed to commit: %v", err)
+	}
+
+	// Verify update
+	actualDeployments, err := getDeployments(t.Context(), workspaceID)
+	if err != nil {
+		t.Fatalf("expected no errors, got %v", err)
+	}
+
+	if len(actualDeployments) != 1 {
+		t.Fatalf("expected 1 deployment, got %d", len(actualDeployments))
+	}
+
+	actualDeployment := actualDeployments[0]
+	if actualDeployment.ResourceSelector == nil {
+		t.Fatalf("expected resource selector to be non-nil")
+	}
+
+	// Validate it's now a CEL selector
+	celSelector, err := actualDeployment.ResourceSelector.AsCelSelector()
+	if err != nil {
+		t.Fatalf("expected CEL selector, got error: %v", err)
+	}
+
+	if celSelector.Cel != celExpression {
+		t.Fatalf("expected CEL expression %s, got %s", celExpression, celSelector.Cel)
+	}
+}