fix: add error handler to api router

Author: adityachoudhari26

apps/api/src/middleware/error-handler.ts

@@ -6,8 +6,15 @@ import { logger } from "@ctrlplane/logger";
 /**
  * Global error handler middleware
  * Must be registered last in the middleware chain
+ *
+ * Note: Must have 4 parameters for Express to recognize it as an error handler
  */
-export const errorHandler = (error: Error, req: Request, res: Response) => {
+export const errorHandler = (
+  error: Error,
+  req: Request,
+  res: Response,
+  _next: any,
+) => {
   // Log the error
   logger.error("API Error", {
     error: error.message,

apps/api/src/routes/v1/workspaces/deployments.ts

@@ -60,10 +60,7 @@ const getDeployment: AsyncTypedHandler<
   );
 
   if (response.error != null)
-    throw new ApiError(
-      `Error getting deployment: ${JSON.stringify(response.error, null, 2)}`,
-      500,
-    );
+    throw new ApiError(response.error.error ?? "Unknown error", 500);
 
   res.json(response.data);
 };

apps/api/src/server.ts

@@ -1,6 +1,7 @@
 import { dirname, join } from "path";
 import { fileURLToPath } from "url";
 import { requireAuth } from "@/middleware/auth.js";
+import { errorHandler } from "@/middleware/error-handler.js";
 import { createV1Router } from "@/routes/index.js";
 import * as trpcExpress from "@trpc/server/adapters/express";
 import { toNodeHandler } from "better-auth/node";
@@ -78,6 +79,7 @@ const app = express()
   .use("/api/v1", requireAuth)
   .use("/api/v1", createV1Router())
   .use("/api/github", createGithubRouter())
-  .use("/api/trpc", trpcMiddleware);
+  .use("/api/trpc", trpcMiddleware)
+  .use(errorHandler);
 
 export { app };