chore: add traces to taint processor

Author: adityachoudhari26

apps/workspace-engine/pkg/workspace/releasemanager/targets/taint.go

@@ -1,11 +1,17 @@
 package targets
 
 import (
+	"context"
 	"workspace-engine/pkg/changeset"
 	"workspace-engine/pkg/oapi"
 	"workspace-engine/pkg/workspace/store"
+
+	"go.opentelemetry.io/otel"
+	"go.opentelemetry.io/otel/attribute"
 )
 
+var tainProcessorTracer = otel.Tracer("TaintProcessor")
+
 // targetIndex provides efficient lookups of targets by their related entity IDs
 type targetIndex struct {
 	byEnvironment map[string][]*oapi.ReleaseTarget
@@ -32,18 +38,21 @@ func buildTargetIndex(targets map[string]*oapi.ReleaseTarget) *targetIndex {
 
 // TaintProcessor identifies which targets need to be re-evaluated based on changes
 type TaintProcessor struct {
+	ctx            context.Context
 	store          *store.Store
 	index          *targetIndex
 	taintedTargets map[string]*oapi.ReleaseTarget
 }
 
 // NewTaintProcessor creates a new taint processor and processes all changes in a single pass
 func NewTaintProcessor(
+	ctx context.Context,
 	store *store.Store,
 	changeSet *changeset.ChangeSet[any],
 	targets map[string]*oapi.ReleaseTarget,
 ) *TaintProcessor {
 	tp := &TaintProcessor{
+		ctx:            ctx,
 		store:          store,
 		index:          buildTargetIndex(targets),
 		taintedTargets: make(map[string]*oapi.ReleaseTarget),
@@ -56,7 +65,11 @@ func NewTaintProcessor(
 // processChanges iterates through the changeset once and taints relevant targets
 // This replaces the previous approach of calling Process() multiple times
 func (tp *TaintProcessor) processChanges(changeSet *changeset.ChangeSet[any]) {
+	_, span := tainProcessorTracer.Start(tp.ctx, "processChanges")
+	defer span.End()
+
 	items := changeSet.Process().CollectEntities()
+	span.SetAttributes(attribute.Int("changeset.count", len(items)))
 	for _, item := range items {
 		switch entity := item.(type) {
 		case *oapi.Policy, *oapi.System:
@@ -113,31 +126,50 @@ func (tp *TaintProcessor) taintAll() {
 
 // taintByEnvironment taints all targets in the given environment
 func (tp *TaintProcessor) taintByEnvironmentId(envId string) {
+	_, span := tainProcessorTracer.Start(tp.ctx, "taintByEnvironmentId")
+	defer span.End()
+
+	span.SetAttributes(attribute.String("environment.id", envId))
 	for _, target := range tp.index.byEnvironment[envId] {
 		tp.taintedTargets[target.Key()] = target
 	}
 }
 
 // taintByDeployment taints all targets for the given deployment
 func (tp *TaintProcessor) taintByDeploymentId(depId string) {
+	_, span := tainProcessorTracer.Start(tp.ctx, "taintByDeploymentId")
+	defer span.End()
+
+	span.SetAttributes(attribute.String("deployment.id", depId))
 	for _, target := range tp.index.byDeployment[depId] {
 		tp.taintedTargets[target.Key()] = target
 	}
 }
 
 // taintByResource taints all targets for the given resource
 func (tp *TaintProcessor) taintByResourceId(resId string) {
+	_, span := tainProcessorTracer.Start(tp.ctx, "taintByResourceId")
+	defer span.End()
+
 	for _, target := range tp.index.byResource[resId] {
 		tp.taintedTargets[target.Key()] = target
 	}
 }
 
 // taintByJob taints the specific target associated with the job's release
 func (tp *TaintProcessor) taintByReleaseTarget(releaseTarget *oapi.ReleaseTarget) {
+	_, span := tainProcessorTracer.Start(tp.ctx, "taintByReleaseTarget")
+	defer span.End()
+
+	span.SetAttributes(attribute.String("release_target.key", releaseTarget.Key()))
 	tp.taintedTargets[releaseTarget.Key()] = releaseTarget
 }
 
 // Tainted returns the map of all targets that have been marked for tainting
 func (tp *TaintProcessor) Tainted() map[string]*oapi.ReleaseTarget {
+	_, span := tainProcessorTracer.Start(tp.ctx, "Tainted")
+	defer span.End()
+
+	span.SetAttributes(attribute.Int("tainted_targets.count", len(tp.taintedTargets)))
 	return tp.taintedTargets
 }

apps/workspace-engine/pkg/workspace/releasemanager/targets/taint_test.go

@@ -1,7 +1,6 @@
 package targets
 
 import (
-	"context"
 	"testing"
 	"time"
 	"workspace-engine/pkg/changeset"
@@ -142,6 +141,7 @@ func TestBuildTargetIndex(t *testing.T) {
 
 // Test taint on Policy change (should taint all targets)
 func TestTaintProcessor_PolicyChange_TaintsAll(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -165,7 +165,7 @@ func TestTaintProcessor_PolicyChange_TaintsAll(t *testing.T) {
 	cs.Record(changeset.ChangeTypeCreate, policy)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify all targets are tainted
@@ -176,6 +176,7 @@ func TestTaintProcessor_PolicyChange_TaintsAll(t *testing.T) {
 
 // Test taint on System change (should taint all targets)
 func TestTaintProcessor_SystemChange_TaintsAll(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -199,7 +200,7 @@ func TestTaintProcessor_SystemChange_TaintsAll(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, system)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify all targets are tainted
@@ -210,6 +211,7 @@ func TestTaintProcessor_SystemChange_TaintsAll(t *testing.T) {
 
 // Test taint on Environment change
 func TestTaintProcessor_EnvironmentChange_TaintsEnvironmentTargets(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -234,7 +236,7 @@ func TestTaintProcessor_EnvironmentChange_TaintsEnvironmentTargets(t *testing.T)
 	cs.Record(changeset.ChangeTypeUpdate, env)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify only env1 targets are tainted
@@ -245,6 +247,7 @@ func TestTaintProcessor_EnvironmentChange_TaintsEnvironmentTargets(t *testing.T)
 
 // Test taint on Deployment change
 func TestTaintProcessor_DeploymentChange_TaintsDeploymentTargets(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -268,7 +271,7 @@ func TestTaintProcessor_DeploymentChange_TaintsDeploymentTargets(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, dep)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify only dep1 targets are tainted
@@ -279,6 +282,7 @@ func TestTaintProcessor_DeploymentChange_TaintsDeploymentTargets(t *testing.T) {
 
 // Test taint on DeploymentVersion change
 func TestTaintProcessor_DeploymentVersionChange_TaintsDeploymentTargets(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -302,7 +306,7 @@ func TestTaintProcessor_DeploymentVersionChange_TaintsDeploymentTargets(t *testi
 	cs.Record(changeset.ChangeTypeCreate, version)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify only dep1 targets are tainted
@@ -313,6 +317,7 @@ func TestTaintProcessor_DeploymentVersionChange_TaintsDeploymentTargets(t *testi
 
 // Test taint on Resource change
 func TestTaintProcessor_ResourceChange_TaintsResourceTargets(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -336,7 +341,7 @@ func TestTaintProcessor_ResourceChange_TaintsResourceTargets(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, resource)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify only resID1 targets are tainted
@@ -347,7 +352,7 @@ func TestTaintProcessor_ResourceChange_TaintsResourceTargets(t *testing.T) {
 
 // Test taint on Job change
 func TestTaintProcessor_JobChange_TaintsJobReleaseTarget(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -379,7 +384,7 @@ func TestTaintProcessor_JobChange_TaintsJobReleaseTarget(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, job)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify only the target associated with the job's release is tainted
@@ -390,6 +395,7 @@ func TestTaintProcessor_JobChange_TaintsJobReleaseTarget(t *testing.T) {
 
 // Test taint with job that has non-existent release
 func TestTaintProcessor_JobChange_NonExistentRelease(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -409,7 +415,7 @@ func TestTaintProcessor_JobChange_NonExistentRelease(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, job)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify no targets are tainted
@@ -418,6 +424,7 @@ func TestTaintProcessor_JobChange_NonExistentRelease(t *testing.T) {
 
 // Test multiple changes in single pass
 func TestTaintProcessor_MultipleChanges_SinglePass(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -450,7 +457,7 @@ func TestTaintProcessor_MultipleChanges_SinglePass(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, resource)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify all targets are tainted (target1 by env+dep, target2 by dep+res, target3 by env+res)
@@ -462,6 +469,7 @@ func TestTaintProcessor_MultipleChanges_SinglePass(t *testing.T) {
 
 // Test empty changeset
 func TestTaintProcessor_EmptyChangeset(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -479,7 +487,7 @@ func TestTaintProcessor_EmptyChangeset(t *testing.T) {
 	cs := changeset.NewChangeSet[any]()
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify no targets are tainted
@@ -488,6 +496,7 @@ func TestTaintProcessor_EmptyChangeset(t *testing.T) {
 
 // Test that Policy change short-circuits (taints all and returns early)
 func TestTaintProcessor_PolicyChange_ShortCircuits(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -514,7 +523,7 @@ func TestTaintProcessor_PolicyChange_ShortCircuits(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, env)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify all targets are tainted (policy should cause all to be tainted and return early)
@@ -525,6 +534,7 @@ func TestTaintProcessor_PolicyChange_ShortCircuits(t *testing.T) {
 
 // Test with no targets
 func TestTaintProcessor_NoTargets(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 	targets := map[string]*oapi.ReleaseTarget{}
@@ -535,7 +545,7 @@ func TestTaintProcessor_NoTargets(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, env)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify no targets are tainted (because there are none)
@@ -544,6 +554,7 @@ func TestTaintProcessor_NoTargets(t *testing.T) {
 
 // Test taint deduplication (same target tainted by multiple changes)
 func TestTaintProcessor_Deduplication(t *testing.T) {
+	ctx := t.Context()
 	sc := statechange.NewChangeSet[any]()
 	st := store.New(sc)
 
@@ -568,7 +579,7 @@ func TestTaintProcessor_Deduplication(t *testing.T) {
 	cs.Record(changeset.ChangeTypeUpdate, resource)
 
 	// Process
-	tp := NewTaintProcessor(st, cs, targets)
+	tp := NewTaintProcessor(ctx, st, cs, targets)
 	tainted := tp.Tainted()
 
 	// Verify target is tainted only once (deduplication works)

apps/workspace-engine/pkg/workspace/releasemanager/targets/targets_manager.go

@@ -51,7 +51,7 @@ func (m *Manager) DetectChanges(ctx context.Context, changeSet *changeset.Change
 	})
 	defer changes.Finalize()
 
-	taintedTargets := NewTaintProcessor(m.store, changeSet, targets).Tainted()
+	taintedTargets := NewTaintProcessor(ctx, m.store, changeSet, targets).Tainted()
 
 	var numTainted int
 	var numCreated int