Skip to content

Commit dd039ab

Browse files
committed
add logging
1 parent ba11109 commit dd039ab

File tree

5 files changed

+15
-5
lines changed

5 files changed

+15
-5
lines changed

apps/workspace-engine/main.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,19 +166,23 @@ func main() {
166166
log.Info("Kafka consumer started")
167167
if err := kafka.RunConsumer(ctx); err != nil {
168168
log.Error("received error from kafka consumer", "error", err)
169+
panic(err)
169170
}
170171
}()
171172

172173
go func() {
173174
log.Info("Workspace engine server started", "address", addr)
174175
if err := router.Run(addr); err != nil {
175176
log.Fatal("Failed to serve", "error", err)
177+
panic(err)
176178
}
177179
}()
178180

179181
sigChan := make(chan os.Signal, 1)
180182
signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
183+
181184
<-sigChan
182185

186+
producer.Close()
183187
log.Info("Shutting down workspace engine...")
184188
}

apps/workspace-engine/pkg/events/handler/handler.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ func (el *EventListener) ListenAndRoute(ctx context.Context, msg *kafka.Message,
167167

168168
ctx = changeset.WithChangeSet(ctx, changeSet)
169169

170+
log.Info("Processing event", "eventType", rawEvent.EventType, "workspaceID", rawEvent.WorkspaceID)
170171
if err := handler(ctx, ws, rawEvent); err != nil {
171172
span.RecordError(err)
172173
span.SetStatus(codes.Error, "handler failed")

apps/workspace-engine/pkg/events/handler/resources/resources.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package resources
22

33
import (
44
"context"
5-
"errors"
65
"workspace-engine/pkg/events/handler"
76
"workspace-engine/pkg/oapi"
87
"workspace-engine/pkg/workspace"
@@ -20,9 +19,7 @@ func HandleResourceCreated(
2019
return err
2120
}
2221

23-
if resource.WorkspaceId != ws.ID {
24-
return errors.New("resource workspace id does not match workspace id")
25-
}
22+
resource.WorkspaceId = ws.ID
2623

2724
if _, err := ws.Resources().Upsert(ctx, resource); err != nil {
2825
return err

apps/workspace-engine/pkg/workspace/loader.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,13 @@ func Load(ctx context.Context, storage StorageClient, workspace *Workspace) erro
7373

7474
data, err := storage.Get(ctx, dbSnapshot.Path)
7575
if err != nil {
76-
return fmt.Errorf("failed to read workspace from disk: %w", err)
76+
span.RecordError(err)
77+
span.SetStatus(codes.Error, "Failed to read workspace from disk")
78+
log.Warn("Failed to read workspace from disk, populating workspace with initial state", "workspaceID", workspace.ID, "error", err)
79+
if err := PopulateWorkspaceWithInitialState(ctx, workspace); err != nil {
80+
return fmt.Errorf("failed to populate workspace with initial state: %w", err)
81+
}
82+
return nil
7783
}
7884

7985
span.AddEvent("loaded workspace from disk")

packages/events/src/kafka/client.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,14 @@ export const sendGoEvent = createSpanWrapper(
5151
value: JSON.stringify(message),
5252
})),
5353
});
54+
log.info("Sent event", { messages });
5455
} catch (error) {
5556
const err = error instanceof Error ? error : new Error(String(error));
5657
span.setStatus({
5758
code: SpanStatusCode.ERROR,
5859
message: err.message,
5960
});
61+
log.error("Failed to send event", { error });
6062
throw error;
6163
}
6264
},

0 commit comments

Comments
 (0)