Update to latest linting rules and for real release 0.14.11

Author: evert

.eslintrc.json

@@ -26,6 +26,9 @@
         "SwitchCase": 1
       }],
       "linebreak-style": ["error", "unix"],
+      "no-constant-condition": ["error", {
+        "checkLoops": false
+      }],
       "quotes": ["error", "single",
           {
             "allowTemplateLiterals": false,
@@ -35,14 +38,30 @@
       "semi": ["error", "always"],
       "no-trailing-spaces": "error",
       "eol-last": "error",
-      "@typescript-eslint/no-inferrable-types": "off",
       "@typescript-eslint/ban-ts-comment": ["error",
         {
           "ts-expect-error": "allow-with-description"
         }
       ],
+      "@typescript-eslint/ban-tslint-comment": "error",
+      "@typescript-eslint/consistent-type-assertions": ["error", {
+        "assertionStyle": "as",
+        "objectLiteralTypeAssertions": "never"
+      }],
+      "@typescript-eslint/member-delimiter-style": "error",
+      "@typescript-eslint/no-inferrable-types": "off",
       "@typescript-eslint/no-explicit-any" : 0,
-      "@typescript-eslint/no-unused-vars": ["error"],
+      "@typescript-eslint/no-for-in-array": "error",
+      "@typescript-eslint/no-invalid-void-type": "error",
+      "@typescript-eslint/no-namespace": "error",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "error",
+      "@typescript-eslint/no-unused-vars": ["error", {
+        "ignoreRestSiblings": true,
+        "args": "none"
+      }],
+      "@typescript-eslint/prefer-for-of": ["error"],
+      "@typescript-eslint/prefer-optional-chain": ["error"],
+      "@typescript-eslint/prefer-ts-expect-error": ["error"],
       "no-console": ["error"]
   }
 }

changelog.md

@@ -1,7 +1,7 @@
 Changelog
 =========
 
-0.14.11 (2021-04-28)
+0.14.11 (2021-05-23)
 --------------------
 
 * Upgrade to Ketting 7 for parsing hypermedia bodies.

package-lock.json

@@ -7,7 +7,7 @@ type Type = {
   [s: string]: {
     label: string;
     cssClass: string;
-  }
+  };
 };
 
 const types: Type = {

src/components/alternate.tsx

@@ -3,11 +3,11 @@ import { Action, Field } from 'ketting';
 import { Button } from './button';
 
 type FormProps = {
-  csrfToken: string | null,
-  action: Action
+  csrfToken: string | null;
+  action: Action;
 }
 type FieldProps = {
-  field: Field,
+  field: Field;
 }
 
 /**

src/components/forms/ketting-action-button.tsx

@@ -3,11 +3,11 @@ import { Action, Field } from 'ketting';
 import { Button } from './button';
 
 type FormProps = {
-  csrfToken: string | null,
-  action: Action
+  csrfToken: string | null;
+  action: Action;
 }
 type FieldProps = {
-  field: Field,
+  field: Field;
 }
 
 export function ActionForm(props: FormProps) {

src/components/forms/ketting-action.tsx

@@ -3,9 +3,9 @@ import { PageProps } from '../../types';
 import { Button } from './button';
 
 type Field = {
-  label: string,
-  value: string,
-  name: string
+  label: string;
+  value: string;
+  name: string;
 };
 
 export function TemplatedLinks(props: PageProps) {

src/components/forms/templated-links.tsx

@@ -5,8 +5,8 @@ import * as React from 'react';
 import { Options } from '../types';
 
 type Props = {
-  options: Options,
-  resourceState: State,
+  options: Options;
+  resourceState: State;
 };
 
 export function Search(props: Props) {

src/components/search.tsx

@@ -158,7 +158,7 @@ export default function browser(options?: Partial<Options>): Middleware {
     // If Content-Disposition: attachment was set, it means the API author
     // intended to create a download, we will also not render HTML.
     const cd = ctx.response.headers.get('Content-Disposition');
-    if (cd && cd.startsWith('attachment')) {
+    if (cd?.startsWith('attachment')) {
       return;
     }
 

src/index.ts

@@ -9,56 +9,56 @@ export type Options = {
   /**
    * Application title
    */
-  title: string,
+  title: string;
 
   /**
    * Theme
    *
    * Possible options: spicy-oj, lfo, curveball
    */
-  theme: 'spicy-oj' | 'lfo' | 'curveball' | 'xmas',
+  theme: 'spicy-oj' | 'lfo' | 'curveball' | 'xmas';
 
   /**
    * List of custom stylesheets to embed.
    *
    * Note that setting this will cause 'theme' to be ignored.
    */
-  stylesheets: string[],
+  stylesheets: string[];
 
   /**
    * List of links that should be lifted to navigation sections
    */
-  navigationLinks: SureNavigationLinkMap,
+  navigationLinks: SureNavigationLinkMap;
 
   /**
    * Where the base assets are located
    */
-  assetBaseUrl: string,
+  assetBaseUrl: string;
 
   /**
    * Should this plugin handle serving the assets.
    *
    * Disable if the assets are hosted elsewhere
    */
-  serveAssets: boolean,
+  serveAssets: boolean;
 
   /**
    * List of hardcoded links that should show up on every page.
    */
-  defaultLinks: Link[],
+  defaultLinks: Link[];
 
   /**
    * List of uninteresting link relationships that should be hidden by default.
    */
-  hiddenRels: string[],
+  hiddenRels: string[];
 
   /**
    * If turned on, full JSON bodies are always rendered.
    *
    * This can also be turned on during runtime by adding a ?_browser-fullbody
    * query parameter
    */
-  fullBody: boolean,
+  fullBody: boolean;
 };
 
 /**
@@ -67,7 +67,7 @@ export type Options = {
 export type NavigationLinkMap = {
 
   // Navigation links are nullable so they can be overridden
-  [rel: string]: NavigationLink | null | true
+  [rel: string]: NavigationLink | null | true;
 
 };
 
@@ -79,7 +79,7 @@ export type NavigationLinkMap = {
 export type SureNavigationLinkMap = {
 
   // Navigation links are nullable so they can be overridden
-  [rel: string]: NavigationLink
+  [rel: string]: NavigationLink;
 
 };
 
@@ -95,28 +95,28 @@ export type NavigationPosition = 'header' | 'header-right' | 'pager' | 'alternat
 export type NavigationLink = {
 
   // A CSS class. If it's not specified, we'll default to "rel-" + rel
-  cssClass?: string,
+  cssClass?: string;
 
   // A title we'll put in the HTML title= attribute if it wasn't overriden.
-  defaultTitle?: string,
+  defaultTitle?: string;
 
   // A relative URI to an icon. If it's not specified, we'll default to
   // [rel].svg
-  icon?: string,
+  icon?: string;
 
   // Where the icon should appear
-  position?: NavigationPosition,
+  position?: NavigationPosition;
 
   // Set this to to make an icon appear earlier or later. Default is 0, lower is earlier.
-  priority?: number,
+  priority?: number;
 
   // Whether or not to show the 'title' as the button label.
-  showLabel?: boolean
+  showLabel?: boolean;
 
 };
 
 export type PageProps = {
-  resourceState: State,
-  options: Options,
-  csrfToken: string | null,
+  resourceState: State;
+  options: Options;
+  csrfToken: string | null;
 }