Skip to content

Commit bcf7ede

Browse files
committed
Small update
1 parent ed718d9 commit bcf7ede

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

dsp/saddle_extremum.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ def concave_variables(self) -> list[cp.Variable]:
7373
raise NotImplementedError
7474

7575
def _grad(self, values) -> NoReturn:
76-
# This is an abstract method in the `Atom` superclass but appears unused in the dsp library
77-
# Implementation here to prevent `TypeError: Can't instantiate abstract class...`
76+
# This is an abstract method in the `Atom` superclass but is unused in dsp
7877
raise NotImplementedError
7978

8079

@@ -243,7 +242,7 @@ def __init__(self, f: cp.Expression) -> None:
243242
y_vars = [cp.Variable(name=f"{x.name()}_conjugate", shape=x.shape) for x in x_vars]
244243

245244
obj = -f
246-
for x, y in zip(x_vars, y_vars, strict=False):
245+
for x, y in zip(x_vars, y_vars, strict=True):
247246
obj += dsp.inner(cp.vec(y), cp.vec(x))
248247

249248
super().__init__(obj, [])

0 commit comments

Comments
 (0)