Allow pnpm as package manager

Author: jvanbruegge

packages/create-cycle-app/index.js

@@ -11,6 +11,7 @@ const validCommands = {
   'verbose': true,
   'flavor': true,
   'yarn': true,
+  'pnpm': true,
   'forceprompt': true
 }
 
@@ -21,7 +22,7 @@ if (commands.length === 0) {
     console.log(chalk.green(`create-cycle-app version: ${VERSION}`))
     process.exit()
   }
-  console.error(chalk.red('Usage: create-cycle-app <project-directory> [--flavor] [--verbose] [--yarn]'))
+  console.error(chalk.red('Usage: create-cycle-app <project-directory> [--flavor] [--verbose] [--yarn | --pnpm]'))
   process.exit(1)
 }
 
@@ -38,9 +39,9 @@ Object.keys(argv)
 
 const flavor = argv.flavor || 'core'
 const verbose = argv.verbose || false
-const yarn = argv.yarn || false
+const cli = argv.yarn ? 'yarn' : (argv.pnpm ? 'pnpm' : 'npm')
 const forceprompt = argv.forceprompt || false
 const name = commands[0]
 
 // Parse the command line options and run the setup
-createApp(name, verbose, flavor, yarn, forceprompt)
+createApp(name, verbose, flavor, cli, forceprompt)

packages/create-cycle-app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "create-cycle-app",
-  "version": "4.0.0",
+  "version": "4.1.0-rc.1",
   "description": "Create Cycle.js with no build configuration.",
   "scripts": {
     "test": "jest"

packages/create-cycle-app/src/createApp.js

@@ -8,14 +8,13 @@ const installScripts = require('./installScripts')
 const createPackageJson = require('./createPackageJson')
 const shouldUseYarn = require('./shouldUseYarn')
 
-module.exports = function createApp (name, verbose, flavor, yarn, forceprompt) {
+module.exports = function createApp (name, verbose, flavor, cli, forceprompt) {
   // The path where the cycle app will be created
   const appPath = path.resolve(name)
   // The name of the cycle app to create
   const appName = path.basename(appPath)
   // Which CLi to use (yarn or npm)
-  let cli = 'npm'
-  if (yarn || shouldUseYarn()) {
+  if (shouldUseYarn()) {
     cli = 'yarn'
   }
   // console.log(cli)

packages/create-cycle-app/src/installScripts.js

@@ -17,17 +17,21 @@ module.exports = function installScripts (appFolder, appName, options) {
   // Get the right name of the flavor package
   const packageName = getPackageName(flavor)
   // Install dependencies
+  const npmArgs = [
+    'install',
+    verbose && '--verbose',
+    '--save-dev',
+    '--save-exact',
+    flavor
+  ].filter(a => a)
+
   const args = {
-    npm: [
-      'install',
-      verbose && '--verbose',
-      '--save-dev',
-      '--save-exact',
-      flavor
-    ].filter(a => a),
+    npm: npmArgs,
+    pnpm: npmArgs,
     yarn: [
       'add',
       '--exact',
+      '--dev',
       verbose && '--verbose',
       local ? 'file:' + flavor : flavor
     ].filter(a => a)

packages/create-cycle-app/test/integration/__snapshots__/createCycleApp.spec.js.snap

@@ -1,21 +1,23 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
 exports[`create-cycle-app when invoked with the the correct arguments it generate a correct package.json file 1`] = `
 "{
-  \"name\": \"MYCYCLEAPP\",
-  \"version\": \"0.1.0\",
-  \"private\": true,
-  \"devDependencies\": {
-    \"cycle-scripts\": \"1.0.3\"
+  "name": "MYCYCLEAPP",
+  "version": "0.1.0",
+  "private": true,
+  "devDependencies": {
+    "cycle-scripts": "1.0.3"
   },
-  \"dependencies\": {},
-  \"scripts\": {
-    \"start\": \"cycle-scripts start\",
-    \"test\": \"cycle-scripts test\",
-    \"build\": \"cycle-scripts build\",
-    \"eject\": \"cycle-scripts eject\"
+  "dependencies": {},
+  "scripts": {
+    "start": "cycle-scripts start",
+    "test": "cycle-scripts test",
+    "build": "cycle-scripts build",
+    "eject": "cycle-scripts eject"
   },
-  \"babel\": {
-    \"presets\": [
-      \"es2015\"
+  "babel": {
+    "presets": [
+      "es2015"
     ]
   }
 }"