Skip to content

Commit b34d23c

Browse files
authored
fix accessibility violations on react button docs (#625)
1 parent c4bc551 commit b34d23c

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

components/Button/assertions.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export default function assertions(
2626
'text-decoration-line',
2727
'underline',
2828
)
29-
cy
3029
})
3130

3231
it('renders variants', () => {

components/Button/react/Button.rootstory.tsx

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default ({
99
href,
1010
onClick,
1111
}: { disabled?: boolean; href?: string; onClick?: () => void } = {}) => (
12-
<div className="flex flex-row flex-wrap justify-center gap-2">
12+
<div className="flex flex-row flex-wrap justify-center gap-2 bg-white">
1313
{(Object.keys(CssVariantClassesTable) as ButtonVariants[]).map(
1414
(variant) => {
1515
return (
@@ -37,26 +37,19 @@ export default ({
3737
return (
3838
<div key={size} className="flex items-center justify-center">
3939
<span
40-
className={clsx('text-sm mr-4', {
41-
'text-gray-300':
42-
variant === 'outline-dark' ||
40+
className={clsx(
41+
'text-sm mr-4',
42+
variant === 'outline-dark' ||
4343
variant === 'outline-red-dark-mode' ||
4444
variant === 'outline-jade-dark-mode' ||
4545
variant === 'outline-indigo-dark-mode' ||
4646
variant === 'outline-purple-dark-mode' ||
4747
variant === 'red-dark-mode' ||
4848
variant === 'indigo-dark-mode' ||
49-
variant === 'disabled-dark-mode',
50-
'text-gray-700': ![
51-
'outline-dark',
52-
'outline-red-dark-mode',
53-
'outline-jade-dark-mode',
54-
'outline-indigo-dark-mode',
55-
'red-dark-mode',
56-
'indigo-dark-mode',
57-
'disabled-dark-mode',
58-
].includes(variant),
59-
})}
49+
variant === 'disabled-dark-mode'
50+
? 'text-gray-300'
51+
: 'text-gray-900',
52+
)}
6053
>
6154
{size}
6255
</span>

0 commit comments

Comments
 (0)