-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: update Cypress tests to Node.js 22.15.1 #6229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update Cypress tests to Node.js 22.15.1 #6229
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
Logs shows expected versions:
although there is still a strange section referring to audio hardware:
This looks like it would belong to the class of "garbage errors". In any case the pipeline succeeds, despite these errors, which is also a typical experience for a "garbage error". |
Please review! I'm guessing that you intended to have everything running in Node.js I just happened to notice this all because I submitted a text update to the site and I wondered why the Cypress tests were still being run in Node.js At some stage probably Cypress ought to be updated from its current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MikeMcC399. I overlooked the cypress node version being run here. eventually we do need to do some dependency updating here
Situation
Current CircleCI jobs are now running in two different Node.js environments
18.16.1
and22.15.1
docker.io/cimg/node:22.15.1
ubuntu-2204:2024.11.1
/docker.io/cimg/node:22.15.1
docker.io/cimg/node:22.15.1
docker.io/cimg/node:18.16.1-browsers
docker.io/cimg/node:18.16.1-browsers
It doesn't seem like this would have been the intention. Node.js
18.x
is end-of-life and deprecated by Cypress. With the release of Cypress 15, this version of Node.js will transition into being unsupported by Cypress and the minimum Node.js will become version 20.Assessment
The configuration .circleci/config.yml for the jobs:
relies on
executor: cypress/default
taken fromcypress-documentation/.circleci/config.yml
Lines 3 to 4 in 3a428ac
The default Node.js version for
cypress: cypress-io/cypress@3
, equivalent to cypress-io/[email protected], is Node.js 18.16.1The default Node.js version for
cypress: cypress-io/cypress@4
, equivalent to cypress-io/[email protected], is Node.js 22.15.0Change
In the configuration .circleci/config.yml:
cypress: cypress-io/cypress@3
tocypress: cypress-io/cypress@4
(currentlatest
)and in the jobs "Install & Persist To Workspace" and "Run Tests in Parallel"
22.15.1
, to use exactly this version that is being used in the other jobs already