From f048b7555261f25825daef43e89b31a037b97500 Mon Sep 17 00:00:00 2001 From: Bill Glesias Date: Thu, 5 Jun 2025 14:22:32 -0400 Subject: [PATCH] chore: make sure to test against cypress recipes release/15.0.0 branch --- .circleci/workflows.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml index 5a11f23ba7a8..3f44f2d1bbda 100644 --- a/.circleci/workflows.yml +++ b/.circleci/workflows.yml @@ -38,7 +38,7 @@ mainBuildFilters: &mainBuildFilters - /^release\/\d+\.\d+\.\d+$/ # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - 'update-v8-snapshot-cache-on-develop' - - 'feat/add_built_ins_minimal' + - 'chore/test_cypress_recipes_15' # usually we don't build Mac app - it takes a long time # but sometimes we want to really confirm we are doing the right thing @@ -49,7 +49,7 @@ macWorkflowFilters: &darwin-workflow-filters - equal: [ develop, << pipeline.git.branch >> ] # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - - equal: [ 'feat/add_built_ins_minimal', << pipeline.git.branch >> ] + - equal: [ 'chore/test_cypress_recipes_15', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> @@ -60,7 +60,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters - equal: [ develop, << pipeline.git.branch >> ] # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - - equal: [ 'feat/add_built_ins_minimal', << pipeline.git.branch >> ] + - equal: [ 'chore/test_cypress_recipes_15', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> @@ -83,7 +83,7 @@ windowsWorkflowFilters: &windows-workflow-filters - equal: [ develop, << pipeline.git.branch >> ] # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - - equal: [ 'feat/add_built_ins_minimal', << pipeline.git.branch >> ] + - equal: [ 'chore/test_cypress_recipes_15', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> @@ -157,7 +157,7 @@ commands: name: Set environment variable to determine whether or not to persist artifacts command: | echo "Setting SHOULD_PERSIST_ARTIFACTS variable" - echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "feat/add_built_ins_minimal" ]]; then + echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/test_cypress_recipes_15" ]]; then export SHOULD_PERSIST_ARTIFACTS=true fi' >> "$BASH_ENV" # You must run `setup_should_persist_artifacts` command and be using bash before running this command @@ -2708,6 +2708,7 @@ jobs: steps: - test-binary-against-repo: repo: cypress-example-recipes + pull_request_id: 921 command: npm run test:ci:firefox browser: firefox @@ -2716,6 +2717,7 @@ jobs: steps: - test-binary-against-repo: repo: cypress-example-recipes + pull_request_id: 921 command: npm run test:ci:chrome browser: chrome @@ -2725,6 +2727,7 @@ jobs: steps: - test-binary-against-repo: repo: cypress-example-recipes + pull_request_id: 921 # Split the specs up across 4 different machines to run in parallel command: npm run test:ci -- --chunk $CIRCLE_NODE_INDEX --total-chunks $CIRCLE_NODE_TOTAL