Update go -> 1.24.1 & golangci-lint -> 1.64.6 (#3699)

Signed-off-by: joshvanl <[email protected]>

Author: JoshVanL

.build-tools/go.mod

@@ -1,6 +1,6 @@
 module github.com/dapr/components-contrib/build-tools
 
-go 1.23.6
+go 1.24.1
 
 require (
 	github.com/dapr/components-contrib v0.0.0

.github/workflows/components-contrib-all.yml

@@ -65,7 +65,7 @@ jobs:
       GOOS: ${{ matrix.target_os }}
       GOARCH: ${{ matrix.target_arch }}
       GOPROXY: https://proxy.golang.org
-      GOLANGCI_LINT_VER: "v1.61.0"
+      GOLANGCI_LINT_VER: "v1.64.6"
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]

.github/workflows/components-contrib.yml

@@ -33,7 +33,7 @@ jobs:
       GOOS: linux
       GOARCH: amd64
       GOPROXY: https://proxy.golang.org
-      GOLANGCI_LINT_VER: "v1.61.0"
+      GOLANGCI_LINT_VER: "v1.64.6"
     steps:
       - name: Check out code into the Go module directory
         if: ${{ steps.skip_check.outputs.should_skip != 'true' }}

.golangci.yml

@@ -60,7 +60,7 @@ linters-settings:
     # [deprecated] comma-separated list of pairs of the form pkg:regex
     # the regex is used to ignore names within pkg. (default "fmt:.*").
     # see https://github.com/kisielk/errcheck#the-deprecated-method for details
-    ignore: fmt:.*,io/ioutil:^Read.*
+    exclude-functions: fmt:.*,io/ioutil:^Read.*
 
     # path to a file containing a list of functions to exclude from checking
     # see https://github.com/kisielk/errcheck#excluding-functions for details
@@ -285,7 +285,6 @@ linters:
     - unparam
     - wsl
     - mnd
-    - gomnd
     - testpackage
     - err113
     - nestif

bindings/alicloud/dingtalk/webhook/webhook_test.go

@@ -57,11 +57,11 @@ func TestPublishMsg(t *testing.T) { //nolint:paralleltest
 	}}}
 
 	d := NewDingTalkWebhook(logger.NewLogger("test"))
-	err := d.Init(context.Background(), m)
+	err := d.Init(t.Context(), m)
 	require.NoError(t, err)
 
 	req := &bindings.InvokeRequest{Data: []byte(msg), Operation: bindings.CreateOperation, Metadata: map[string]string{}}
-	_, err = d.Invoke(context.Background(), req)
+	_, err = d.Invoke(t.Context(), req)
 	require.NoError(t, err)
 }
 
@@ -78,7 +78,7 @@ func TestBindingReadAndInvoke(t *testing.T) { //nolint:paralleltest
 	}}
 
 	d := NewDingTalkWebhook(logger.NewLogger("test"))
-	err := d.Init(context.Background(), m)
+	err := d.Init(t.Context(), m)
 	require.NoError(t, err)
 
 	var count int32
@@ -92,11 +92,11 @@ func TestBindingReadAndInvoke(t *testing.T) { //nolint:paralleltest
 		return nil, nil
 	}
 
-	err = d.Read(context.Background(), handler)
+	err = d.Read(t.Context(), handler)
 	require.NoError(t, err)
 
 	req := &bindings.InvokeRequest{Data: []byte(msg), Operation: bindings.GetOperation, Metadata: map[string]string{}}
-	_, err = d.Invoke(context.Background(), req)
+	_, err = d.Invoke(t.Context(), req)
 	require.NoError(t, err)
 
 	select {
@@ -117,7 +117,7 @@ func TestBindingClose(t *testing.T) {
 			"id":     "x",
 		},
 	}}
-	require.NoError(t, d.Init(context.Background(), m))
+	require.NoError(t, d.Init(t.Context(), m))
 	require.NoError(t, d.Close())
 	require.NoError(t, d.Close(), "second close should not error")
 }

bindings/alicloud/tablestore/tablestore_test.go

@@ -14,7 +14,6 @@ limitations under the License.
 package tablestore
 
 import (
-	"context"
 	"encoding/json"
 	"os"
 	"testing"
@@ -52,7 +51,7 @@ func TestDataEncodeAndDecode(t *testing.T) {
 	metadata := bindings.Metadata{Base: metadata.Base{
 		Properties: getTestProperties(),
 	}}
-	aliCloudTableStore.Init(context.Background(), metadata)
+	aliCloudTableStore.Init(t.Context(), metadata)
 
 	// test create
 	putData := map[string]interface{}{
@@ -71,7 +70,7 @@ func TestDataEncodeAndDecode(t *testing.T) {
 		Data: data,
 	}
 
-	putInvokeResp, err := aliCloudTableStore.Invoke(context.Background(), putRowReq)
+	putInvokeResp, err := aliCloudTableStore.Invoke(t.Context(), putRowReq)
 
 	require.NoError(t, err)
 	assert.NotNil(t, putInvokeResp)
@@ -82,7 +81,7 @@ func TestDataEncodeAndDecode(t *testing.T) {
 		"column2": int64(2),
 	})
 
-	putInvokeResp, err = aliCloudTableStore.Invoke(context.Background(), putRowReq)
+	putInvokeResp, err = aliCloudTableStore.Invoke(t.Context(), putRowReq)
 
 	require.NoError(t, err)
 	assert.NotNil(t, putInvokeResp)
@@ -102,7 +101,7 @@ func TestDataEncodeAndDecode(t *testing.T) {
 		Data: getData,
 	}
 
-	getInvokeResp, err := aliCloudTableStore.Invoke(context.Background(), getInvokeReq)
+	getInvokeResp, err := aliCloudTableStore.Invoke(t.Context(), getInvokeReq)
 
 	require.NoError(t, err)
 	assert.NotNil(t, getInvokeResp)
@@ -136,7 +135,7 @@ func TestDataEncodeAndDecode(t *testing.T) {
 		Data: listData,
 	}
 
-	listResp, err := aliCloudTableStore.Invoke(context.Background(), listReq)
+	listResp, err := aliCloudTableStore.Invoke(t.Context(), listReq)
 	require.NoError(t, err)
 	assert.NotNil(t, listResp)
 
@@ -164,12 +163,12 @@ func TestDataEncodeAndDecode(t *testing.T) {
 		Data: deleteData,
 	}
 
-	deleteResp, err := aliCloudTableStore.Invoke(context.Background(), deleteReq)
+	deleteResp, err := aliCloudTableStore.Invoke(t.Context(), deleteReq)
 
 	require.NoError(t, err)
 	assert.NotNil(t, deleteResp)
 
-	getInvokeResp, err = aliCloudTableStore.Invoke(context.Background(), getInvokeReq)
+	getInvokeResp, err = aliCloudTableStore.Invoke(t.Context(), getInvokeReq)
 
 	require.NoError(t, err)
 	assert.Nil(t, getInvokeResp.Data)

bindings/apns/apns_test.go

@@ -15,7 +15,6 @@ package apns
 
 import (
 	"bytes"
-	"context"
 	"io"
 	"net/http"
 	"strings"
@@ -52,7 +51,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.NoError(t, err)
 		assert.Equal(t, developmentPrefix, binding.urlPrefix)
 	})
@@ -67,7 +66,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.NoError(t, err)
 		assert.Equal(t, productionPrefix, binding.urlPrefix)
 	})
@@ -81,7 +80,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.NoError(t, err)
 		assert.Equal(t, productionPrefix, binding.urlPrefix)
 	})
@@ -94,7 +93,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.Error(t, err, "the key-id parameter is required")
 	})
 
@@ -107,7 +106,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.NoError(t, err)
 		assert.Equal(t, testKeyID, binding.authorizationBuilder.keyID)
 	})
@@ -120,7 +119,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.Error(t, err, "the team-id parameter is required")
 	})
 
@@ -133,7 +132,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.NoError(t, err)
 		assert.Equal(t, testTeamID, binding.authorizationBuilder.teamID)
 	})
@@ -146,7 +145,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.Error(t, err, "the private-key parameter is required")
 	})
 
@@ -159,7 +158,7 @@ func TestInit(t *testing.T) {
 			},
 		}}
 		binding := NewAPNS(testLogger).(*APNS)
-		err := binding.Init(context.Background(), metadata)
+		err := binding.Init(t.Context(), metadata)
 		require.NoError(t, err)
 		assert.NotNil(t, binding.authorizationBuilder.privateKey)
 	})
@@ -192,7 +191,7 @@ func TestInvoke(t *testing.T) {
 	t.Run("operation must be create", func(t *testing.T) {
 		testBinding := makeTestBinding(t, testLogger)
 		req := &bindings.InvokeRequest{Operation: bindings.DeleteOperation}
-		_, err := testBinding.Invoke(context.TODO(), req)
+		_, err := testBinding.Invoke(t.Context(), req)
 		require.Error(t, err, "operation not supported: delete")
 	})
 
@@ -202,7 +201,7 @@ func TestInvoke(t *testing.T) {
 			Operation: bindings.CreateOperation,
 			Metadata:  map[string]string{},
 		}
-		_, err := testBinding.Invoke(context.TODO(), req)
+		_, err := testBinding.Invoke(t.Context(), req)
 		require.Error(t, err, "the device-token parameter is required")
 	})
 
@@ -213,7 +212,7 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the push type header is sent", func(t *testing.T) {
@@ -224,7 +223,7 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the message ID is sent", func(t *testing.T) {
@@ -235,7 +234,7 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the expiration is sent", func(t *testing.T) {
@@ -246,7 +245,7 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the priority is sent", func(t *testing.T) {
@@ -257,7 +256,7 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the topic is sent", func(t *testing.T) {
@@ -268,7 +267,7 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the collapse ID is sent", func(t *testing.T) {
@@ -279,15 +278,15 @@ func TestInvoke(t *testing.T) {
 
 			return successResponse()
 		})
-		_, _ = testBinding.Invoke(context.TODO(), successRequest)
+		_, _ = testBinding.Invoke(t.Context(), successRequest)
 	})
 
 	t.Run("the message ID is returned", func(t *testing.T) {
 		testBinding := makeTestBinding(t, testLogger)
 		testBinding.client = newTestClient(func(req *http.Request) *http.Response {
 			return successResponse()
 		})
-		response, err := testBinding.Invoke(context.TODO(), successRequest)
+		response, err := testBinding.Invoke(t.Context(), successRequest)
 		require.NoError(t, err)
 		assert.NotNil(t, response.Data)
 		var body notificationResponse
@@ -307,7 +306,7 @@ func TestInvoke(t *testing.T) {
 				Body:       io.NopCloser(strings.NewReader(body)),
 			}
 		})
-		_, err := testBinding.Invoke(context.TODO(), successRequest)
+		_, err := testBinding.Invoke(t.Context(), successRequest)
 		require.Error(t, err, "BadDeviceToken")
 	})
 }
@@ -322,7 +321,7 @@ func makeTestBinding(t *testing.T, log logger.Logger) *APNS {
 			privateKeyKey:  testPrivateKey,
 		},
 	}}
-	err := testBinding.Init(context.Background(), bindingMetadata)
+	err := testBinding.Init(t.Context(), bindingMetadata)
 	require.NoError(t, err)
 
 	return testBinding

bindings/aws/s3/s3_test.go

@@ -14,7 +14,6 @@ limitations under the License.
 package s3
 
 import (
-	"context"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -176,7 +175,7 @@ func TestGetOption(t *testing.T) {
 
 	t.Run("return error if key is missing", func(t *testing.T) {
 		r := bindings.InvokeRequest{}
-		_, err := s3.get(context.Background(), &r)
+		_, err := s3.get(t.Context(), &r)
 		require.Error(t, err)
 	})
 }
@@ -187,7 +186,7 @@ func TestDeleteOption(t *testing.T) {
 
 	t.Run("return error if key is missing", func(t *testing.T) {
 		r := bindings.InvokeRequest{}
-		_, err := s3.delete(context.Background(), &r)
+		_, err := s3.delete(t.Context(), &r)
 		require.Error(t, err)
 	})
 }