Skip to content

Commit 45b93e6

Browse files
authored
refactor: standardize project-wide analysis options (#1842)
1 parent b95f7ea commit 45b93e6

File tree

43 files changed

+69
-102
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+69
-102
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
[![ci][ci_badge]][ci_link]
88
[![coverage][coverage_badge]][ci_link]
9-
[![style: very good analysis][very_good_analysis_badge]][very_good_analysis_link]
9+
[![style: dart frog lint][dart_frog_lint_badge]][dart_frog_lint_link]
1010
[![License: MIT][license_badge]][license_link]
1111
[![Powered by Mason](https://img.shields.io/endpoint?url=https%3A%2F%2Ftinyurl.com%2Fmason-badge)](https://github.com/felangel/mason)
1212

@@ -104,13 +104,13 @@ Dart Frog provides a simple core with a small API surface area in order to reduc
104104
[dart_link]: https://dart.dev
105105
[dart_frog_link_dark]: https://github.com/dart-frog-dev/dart_frog#gh-dark-mode-only
106106
[dart_frog_link_light]: https://github.com/dart-frog-dev/dart_frog#gh-light-mode-only
107+
[dart_frog_lint_badge]: https://img.shields.io/badge/style-dart_frog_lint-1DF9D2.svg
108+
[dart_frog_lint_link]: https://pub.dev/packages/dart_frog_lint
107109
[dart_installation_link]: https://dart.dev/get-dart
108110
[discord_badge]: https://img.shields.io/discord/1394707782271238184?style=for-the-badge&logo=discord&color=1C2A2E&logoColor=1DF9D2
109111
[discord_link]: https://discord.gg/dart-frog
110112
[license_badge]: https://img.shields.io/badge/license-MIT-blue.svg
111113
[license_link]: https://opensource.org/licenses/MIT
112114
[logo_black]: https://raw.githubusercontent.com/dart-frog-dev/dart_frog/main/assets/dart_frog_logo_black.png#gh-light-mode-only
113115
[logo_white]: https://raw.githubusercontent.com/dart-frog-dev/dart_frog/main/assets/dart_frog_logo_white.png#gh-dark-mode-only
114-
[very_good_analysis_badge]: https://img.shields.io/badge/style-very_good_analysis-B22C89.svg
115-
[very_good_analysis_link]: https://pub.dev/packages/very_good_analysis
116116
[very_good_ventures_link]: https://verygood.ventures

analysis_options.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
include: packages/dart_frog_lint/lib/recommended.yaml
12
analyzer:
23
exclude:
34
- bricks/**/__brick__/**
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# {{name.snakeCase()}}
22

3-
[![style: very good analysis][very_good_analysis_badge]][very_good_analysis_link]
3+
[![style: dart frog lint][dart_frog_lint_badge]][dart_frog_lint_link]
44
[![License: MIT][license_badge]][license_link]
55
[![Powered by Dart Frog](https://img.shields.io/endpoint?url=https://tinyurl.com/dartfrog-badge)](https://dart-frog.dev)
66

77
An example application built with dart_frog
88

9+
[dart_frog_lint_badge]: https://img.shields.io/badge/style-dart_frog_lint-1DF9D2.svg
10+
[dart_frog_lint_link]: https://pub.dev/packages/dart_frog_lint
911
[license_badge]: https://img.shields.io/badge/license-MIT-blue.svg
10-
[license_link]: https://opensource.org/licenses/MIT
11-
[very_good_analysis_badge]: https://img.shields.io/badge/style-very_good_analysis-B22C89.svg
12-
[very_good_analysis_link]: https://pub.dev/packages/very_good_analysis
12+
[license_link]: https://opensource.org/licenses/MIT
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
include: package:very_good_analysis/analysis_options.yaml
1+
include: ../../../analysis_options.yaml

bricks/create_dart_frog/hooks/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ dependencies:
1010
dev_dependencies:
1111
mocktail: ^1.0.0
1212
test: ^1.25.0
13-
very_good_analysis: ^9.0.0
Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1 @@
1-
include: package:very_good_analysis/analysis_options.yaml
2-
linter:
3-
rules:
4-
# Experimental and there are lots of false positives
5-
specify_nonobvious_property_types: false
1+
include: ../../../analysis_options.yaml

bricks/dart_frog_dev_server/hooks/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,3 @@ dev_dependencies:
1313
mocktail: ^1.0.0
1414
path: ^1.8.2
1515
test: ^1.25.0
16-
very_good_analysis: ^9.0.0
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
include: package:very_good_analysis/analysis_options.yaml
1+
include: ../../../analysis_options.yaml
22

33
linter:
44
rules:
55
public_member_api_docs: false
6-
# Experimental and there are lots of false positives
7-
specify_nonobvious_property_types: false

bricks/dart_frog_new/hooks/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,3 @@ dependencies:
1212
dev_dependencies:
1313
mocktail: ^1.0.0
1414
test: ^1.19.2
15-
very_good_analysis: ^9.0.0
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
include: package:very_good_analysis/analysis_options.yaml
1+
include: ../../../analysis_options.yaml
22
linter:
33
rules:
4-
public_member_api_docs: false
5-
# Experimental and there are lots of false positives
6-
specify_nonobvious_property_types: false
4+
public_member_api_docs: false

0 commit comments

Comments
 (0)