Skip to content

Conversation

@bdewilde
Copy link
Member

@bdewilde bdewilde commented Oct 27, 2025

changes

  • adds logic to forbid modifying (delete / put / post) data for a review if that review's status is "frozen" (all GET requests are still allowed, i.e. the review's data is read-only)

context

https://app.asana.com/1/6325821815997/project/1206730431337718/task/1206932431234340?focus=true

questions

  • users are allowed to delete frozen reviews. does that seem reasonable?
  • users are allowed to modify frozen reviews (just the review record), so that they can change the status away from "frozen" as needed. technically this allows modifying other attributes of the review. is this okay, or should i confine modifications of frozen reviews to only changing the status?

@bdewilde bdewilde marked this pull request as ready for review October 27, 2025 12:52
@bdewilde bdewilde requested a review from sophiaharms October 27, 2025 12:52
Copy link
Contributor

@sophiaharms sophiaharms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User forbidden to make changes when frozen; changes enabled when review is made active again. Looks good!

@sophiaharms sophiaharms merged commit 8a8e184 into develop Nov 14, 2025
4 checks passed
@sophiaharms sophiaharms deleted the actual-freeze-reviews branch November 14, 2025 21:31
bdewilde added a commit that referenced this pull request Nov 15, 2025
as originally implemented in PR #157
bdewilde added a commit that referenced this pull request Nov 15, 2025
* compute num studies in prisma exports

* actually forbid changes to frozen reviews

as originally implemented in PR #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants