Fixed legacy load pathway for when file_ids is an empty list not None and added a logger

be-smith · be-smith · commit 4194b1fc8367 · 2025-08-22T13:55:44.000+01:00
diff --git a/pydatalab/src/pydatalab/apps/echem/blocks.py b/pydatalab/src/pydatalab/apps/echem/blocks.py
@@ -99,7 +99,8 @@ def _load(self, file_ids: list | ObjectId, reload: bool = True):
         }
 
         # Legacy case for old single file uploads using "file_id"
-        if self.data.get("file_id") is not None and self.data.get("file_ids") is None:
+        if self.data.get("file_id") is not None and not self.data.get("file_ids"):
+            LOGGER.info("Legacy file upload detected, using file_id")
             file_ids = [self.data["file_id"]]
 
         if len(file_ids) == 1:

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,8 @@ def _load(self, file_ids: list \| ObjectId, reload: bool = True):`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`# Legacy case for old single file uploads using "file_id"`
`102`		`- if self.data.get("file_id") is not None and self.data.get("file_ids") is None:`
	`102`	`+ if self.data.get("file_id") is not None and not self.data.get("file_ids"):`
	`103`	`+ LOGGER.info("Legacy file upload detected, using file_id")`
`103`	`104`	`file_ids = [self.data["file_id"]]`
`104`	`105`
`105`	`106`	`if len(file_ids) == 1:`