Add synthesis_products field with self-loop by default

Author: ml-evs

pydatalab/schemas/sample.json

@@ -130,6 +130,14 @@
         "$ref": "#/definitions/Constituent"
       }
     },
+    "synthesis_products": {
+      "title": "Synthesis Products",
+      "default": [],
+      "type": "array",
+      "items": {
+        "$ref": "#/definitions/Constituent"
+      }
+    },
     "synthesis_description": {
       "title": "Synthesis Description",
       "type": "string"

pydatalab/src/pydatalab/models/samples.py

@@ -17,9 +17,23 @@ class Sample(Item):
     synthesis_constituents: List[Constituent] = Field([])
     """A list of references to constituent materials giving the amount and relevant inlined details of consituent items."""
 
+    synthesis_products: List[Constituent] = Field([])
+    """A list of references to constituent materials giving the amount and relevant inlined details of relevant sythesis products."""
+
     synthesis_description: Optional[str]
     """Free-text details of the procedure applied to synthesise the sample"""
 
+    @root_validator
+    def add_self_product(cls, values):
+        if not values.get("synthesis_products"):
+            values["synthesis_products"].append(
+                Constituent(
+                    quantity=None, item={"type": values["type"], "item_id": values["item_id"]}
+                )
+            )
+
+        return values
+
     @root_validator
     def add_missing_synthesis_relationships(cls, values):
         """Add any missing sample synthesis constituents to parent relationships"""

pydatalab/src/pydatalab/routes/v0_1/items.py

@@ -882,7 +882,7 @@ def get_item_data(
     )
 
     # Must be exported to JSON first to apply the custom pydantic JSON encoders
-    return_dict = json.loads(doc.json(exclude_unset=True))
+    return_dict = json.loads(doc.json())
 
     if item_id is None:
         item_id = return_dict["item_id"]