Skip to content

Commit d8216da

Browse files
authored
Merge pull request #207 from datavisyn/develop
Develop
2 parents c148309 + 8e2fd9b commit d8216da

File tree

3 files changed

+78
-14
lines changed

3 files changed

+78
-14
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "tdp_core",
33
"description": "Target discovery platform for exploring rankings of genes, disease models, and other entities.",
44
"homepage": "https://phovea.caleydo.org",
5-
"version": "5.4.0",
5+
"version": "5.4.1",
66
"author": {
77
"name": "datavisyn",
88
"email": "[email protected]",

src/phovea.ts

Lines changed: 68 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,26 @@
66
import {IRegistry} from 'phovea_core/src/plugin';
77

88
export default function (registry: IRegistry) {
9-
function actionFunction(id: string, factory: string, loader: () => any) {
10-
registry.push('actionFunction', id, loader, { factory });
9+
function actionFunction(id: string, factory: string, loader: () => any, options?: {}) {
10+
registry.push('actionFunction', id, loader, { factory, ...options });
1111
}
1212

1313
function actionCompressor(id: string, factory: string, matches: string, loader: () => any) {
1414
registry.push('actionCompressor', id, loader, { factory, matches });
1515
}
1616

17-
actionFunction('tdpInitSession', 'initSessionImpl', () => System.import('./internal/cmds'));
18-
actionFunction('tdpSetParameter', 'setParameterImpl', () => System.import('./internal/cmds'));
17+
actionFunction('tdpInitSession', 'initSessionImpl', () => System.import('./internal/cmds'), {
18+
analytics: {
19+
category: 'session',
20+
action: 'init'
21+
}
22+
});
23+
actionFunction('tdpSetParameter', 'setParameterImpl', () => System.import('./internal/cmds'), {
24+
analytics: {
25+
category: 'view',
26+
action: 'setParameter'
27+
}
28+
});
1929
actionCompressor('tdpCompressSetParameter', 'compressSetParameter', '(tdpSetParameter)', () => System.import('./internal/cmds'));
2030

2131
// compatibility
@@ -24,20 +34,65 @@ export default function (registry: IRegistry) {
2434
actionCompressor('targidCompressSetParameter', 'compressSetParameterOld', '(targidSetParameter)', () => System.import('./internal/cmds'));
2535

2636

27-
actionFunction('tdpAddScore', 'addScoreImpl', () => System.import('./lineup/internal/scorecmds'));
28-
actionFunction('tdpRemoveScore', 'removeScoreImpl', () => System.import('./lineup/internal/scorecmds'));
37+
actionFunction('tdpAddScore', 'addScoreImpl', () => System.import('./lineup/internal/scorecmds'), {
38+
analytics: {
39+
category: 'score',
40+
action: 'add'
41+
}
42+
});
43+
actionFunction('tdpRemoveScore', 'removeScoreImpl', () => System.import('./lineup/internal/scorecmds'), {
44+
analytics: {
45+
category: 'score',
46+
action: 'remove'
47+
}
48+
});
2949
actionCompressor('tdpScoreCompressor', 'compress', '(tdpAddScore|tdpRemoveScore)', () => System.import('./lineup/internal/scorecmds'));
3050

3151
// compatibility
3252
actionFunction('ordinoAddScore', 'addScoreImpl', () => System.import('./lineup/internal/scorecmds'));
3353
actionFunction('ordinoRemoveScore', 'removeScoreImpl', () => System.import('./lineup/internal/scorecmds'));
3454
actionCompressor('ordinoScoreCompressor', 'compressComp', '(ordinoAddScore|ordinoRemoveScore)', () => System.import('./lineup/internal/scorecmds'));
3555

36-
actionFunction('lineupAddRanking', 'addRankingImpl', () => System.import('./lineup/internal/cmds'));
37-
actionFunction('lineupSetRankingSortCriteria', 'setRankingSortCriteriaImpl', () => System.import('./lineup/internal/cmds'));
38-
actionFunction('lineupSetSortCriteria', 'setSortCriteriaImpl', () => System.import('./lineup/internal/cmds'));
39-
actionFunction('lineupSetGroupCriteria', 'setGroupCriteriaImpl', () => System.import('./lineup/internal/cmds'));
40-
actionFunction('lineupSetColumn', 'setColumnImpl', () => System.import('./lineup/internal/cmds'));
41-
actionFunction('lineupAddColumn', 'addColumnImpl', () => System.import('./lineup/internal/cmds'));
42-
actionFunction('lineupMoveColumn', 'moveColumnImpl', () => System.import('./lineup/internal/cmds'));
56+
actionFunction('lineupAddRanking', 'addRankingImpl', () => System.import('./lineup/internal/cmds'), {
57+
analytics: {
58+
category: 'lineup',
59+
action: 'addRanking'
60+
}
61+
});
62+
actionFunction('lineupSetRankingSortCriteria', 'setRankingSortCriteriaImpl', () => System.import('./lineup/internal/cmds'), {
63+
analytics: {
64+
category: 'lineup',
65+
action: 'setRankingSortCriteria'
66+
}
67+
});
68+
actionFunction('lineupSetSortCriteria', 'setSortCriteriaImpl', () => System.import('./lineup/internal/cmds'), {
69+
analytics: {
70+
category: 'lineup',
71+
action: 'setSortCriteria'
72+
}
73+
});
74+
actionFunction('lineupSetGroupCriteria', 'setGroupCriteriaImpl', () => System.import('./lineup/internal/cmds'), {
75+
analytics: {
76+
category: 'lineup',
77+
action: 'setGroupCriteria'
78+
}
79+
});
80+
actionFunction('lineupSetColumn', 'setColumnImpl', () => System.import('./lineup/internal/cmds'), {
81+
analytics: {
82+
category: 'lineup',
83+
action: 'setColumn'
84+
}
85+
});
86+
actionFunction('lineupAddColumn', 'addColumnImpl', () => System.import('./lineup/internal/cmds'), {
87+
analytics: {
88+
category: 'lineup',
89+
action: 'addColumn'
90+
}
91+
});
92+
actionFunction('lineupMoveColumn', 'moveColumnImpl', () => System.import('./lineup/internal/cmds'), {
93+
analytics: {
94+
category: 'lineup',
95+
action: 'moveColumn'
96+
}
97+
});
4398
}

src/views/SelectionChooser.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,4 +179,13 @@ export default class SelectionChooser {
179179
return changed;
180180
}
181181

182+
/**
183+
* change the selected value programmatically
184+
*/
185+
setSelection(value: any) {
186+
const element = <IFormSelectElement>this.accessor(this.formID);
187+
188+
element.value = value;
189+
}
190+
182191
}

0 commit comments

Comments
 (0)