Bug: process polyfill causes issues by virtue of being an ES module

[WasabiThumb]

Summary

Cross-post of readable-stream #539 (for which a reproducible example was made, also on GitHub Pages)
May be related to #98.

This may not chiefly be an issue with vite-plugin-node-polyfills, but it has been observed that in combination with readable-stream and vite that the process polyfill causes errors due to being used as if it is not an ES module, or conversely, not having its default export properly unwrapped. The purpose of this issue is to hopefully help narrow down the code that could least intrusively be updated to fix this incompatibility, for instance (and not primarily), changing vite-plugin-node-polyfills to export a CJS shim via export = process in addition to a default export¹.

¹ Something like (and attempt to fight the urge to vomit) this:

export = Object.assign(process, { process, default: process })

Any insight, especially on how Vite handles ES module interop in combination with this plugin, would be greatly appreciated. ❤️

[davidmyersdev]

Repro: https://stackblitz.com/~/github.com/WasabiThumb/reprex-539

[volkanunsal]

We got bit by this as well. We have a third party library that imports env from process, but since it's an ESM module, it's not touched by CommonJS plugin, and so vite complains about not finding the variable on the exported variables.

error during build:
  node_modules/@aws-sdk/util-user-agent-node/dist-es/index.js (4:9): "env" is not exported by "node_modules/vite-plugin-node-polyfills/shims/process/dist/index.js", imported by "node_modules/@aws-sdk/util-user-agent-node/dist-es/index.js".

import { env } from 'process';

There is another file with cjs extension in the same dist folder that would work, but I'm not sure how to force vite to use that. Do you recommend patching the file to remove the ESM syntax?

[WasabiThumb]

@volkanunsal Sorry to hear you're still dealing with this issue. My PR would resolve it but it needs a little help.