fix(vd): fail with error on insufficient PVC size

When importing VirtualDisk from VirtualImage or ClusterVirtualImage, if PVC size is insufficient, set phase to Failed with error message in Ready condition instead of hanging in Pending without errors.

Signed-off-by: Daniil Loktev [email protected]

Author: loktev-d

images/virtualization-artifact/pkg/controller/vd/internal/source/step/create_dv_from_cvi_step.go

@@ -96,6 +96,11 @@ func (s CreateDataVolumeFromClusterVirtualImageStep) Take(ctx context.Context, v
 	size, err := s.getPVCSize(vd, cviRef)
 	if err != nil {
 		if errors.Is(err, service.ErrInsufficientPVCSize) {
+			vd.Status.Phase = virtv2.DiskFailed
+			s.cb.
+				Status(metav1.ConditionFalse).
+				Reason(vdcondition.ProvisioningFailed).
+				Message(service.CapitalizeFirstLetter(err.Error()) + ".")
 			return &reconcile.Result{}, nil
 		}
 

images/virtualization-artifact/pkg/controller/vd/internal/source/step/create_dv_from_vi_step.go

@@ -99,6 +99,11 @@ func (s CreateDataVolumeFromVirtualImageStep) Take(ctx context.Context, vd *virt
 	size, err := s.getPVCSize(vd, viRef)
 	if err != nil {
 		if errors.Is(err, service.ErrInsufficientPVCSize) {
+			vd.Status.Phase = virtv2.DiskFailed
+			s.cb.
+				Status(metav1.ConditionFalse).
+				Reason(vdcondition.ProvisioningFailed).
+				Message(service.CapitalizeFirstLetter(err.Error()) + ".")
 			return &reconcile.Result{}, nil
 		}