fix(core): fix setting LastTransitionTime in condition if reason changed (#1543)

Signed-off-by: Valeriy Khorunzhin <[email protected]>

Author: eofff

images/virtualization-artifact/pkg/controller/conditions/builder.go

@@ -66,6 +66,8 @@ func SetCondition(c Conder, conditions *[]metav1.Condition) {
 		if !newCondition.LastTransitionTime.IsZero() &&
 			newCondition.LastTransitionTime.After(existingCondition.LastTransitionTime.Time) {
 			existingCondition.LastTransitionTime = newCondition.LastTransitionTime
+		} else {
+			existingCondition.LastTransitionTime = metav1.NewTime(time.Now())
 		}
 	}
 

tests/e2e/default_config.yaml

@@ -48,7 +48,6 @@ logFilter:
   - "the server rejected our request due to an error in our request" # Err.
   - "failed to sync powerstate" # Msg.
   - "does not have a pvc reference" # "err": "kvvm head-345e7b6a-testcases-image-hotplug/head-345e7b6a-vm-image-hotplug spec volume vi-head-345e7b6a-vi-alpine-http does not have a pvc reference"
-  - "lastTransitionTime: Required value" # Err.
   - "virtualmachineipaddressleases.virtualization.deckhouse.io "
   - "Failed to watch" # error if virtualization-controller restarts during tests. "msg": "Failed to watch", "err": "Get \"http://127.0.0.1:23915/apis/virtualization.deckhouse.io/v1alpha2/virtualmachinerestores?allowWatchBookmarks=true\u0026resourceVersion=709816257\u0026timeoutSeconds=310\u0026watch=true\": context canceled"
   - "leader election lost"