fix(audit): improve VM Access message (#1313)

Description
Improve VM Access audit messages. Add stage from audit message to eventLog name.

Why do we need it, and what problem does it solve?
At the moment it is not clear at what stage the request comes when connecting via port-forward, as well as when connecting via console and vnc.

What is the expected result?
Add stage status of request from event message.

---------

Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>

Author: danilrwx

images/virtualization-artifact/pkg/audit/events/vm/vm_access.go

@@ -17,6 +17,8 @@ limitations under the License.
 package vm
 
 import (
+	"fmt"
+
 	"k8s.io/apiserver/pkg/apis/audit"
 
 	"github.com/deckhouse/deckhouse/pkg/log"
@@ -80,9 +82,7 @@ func (m *VMAccess) Fill() error {
 		m.eventLog.Name = "Access to VM via portforward"
 	}
 
-	if m.event.Stage == audit.StageRequestReceived {
-		m.eventLog.Name = "Request " + m.eventLog.Name
-	}
+	m.eventLog.Name = fmt.Sprintf("%s: %s", m.eventLog.Name, m.event.Stage)
 
 	vm, err := util.GetVMFromInformer(m.ttlCache, m.informerList.GetVMInformer(), m.event.ObjectRef.Namespace+"/"+m.event.ObjectRef.Name)
 	if err != nil {

images/virtualization-artifact/pkg/audit/events/vm/vm_access_test.go

@@ -252,33 +252,33 @@ var _ = Describe("VMOP Events", func() {
 			shouldFailMatch: true,
 		}),
 		Entry("VM Access with ResponseComplete should contain decision and fill without errors", vmAccessTestArgs{
-			expectedName:      "Access to VM via serial console",
+			expectedName:      "Access to VM via serial console: ResponseComplete",
 			customSubresource: "console",
 		}),
 		Entry("VM Access with RequestReceived shouldn't contain decision and fill without errors", vmAccessTestArgs{
-			expectedName:      "Request Access to VM via serial console",
+			expectedName:      "Access to VM via serial console: RequestReceived",
 			customSubresource: "console",
 			isRequestReceived: true,
 		}),
 		Entry("VM Access by Console event should filled without errors", vmAccessTestArgs{
-			expectedName:      "Access to VM via serial console",
+			expectedName:      "Access to VM via serial console: ResponseComplete",
 			customSubresource: "console",
 		}),
 		Entry("VM Access by VNC event should filled without errors", vmAccessTestArgs{
-			expectedName:      "Access to VM via VNC",
+			expectedName:      "Access to VM via VNC: ResponseComplete",
 			customSubresource: "vnc",
 		}),
 		Entry("VM Access by Portforward event should filled without errors", vmAccessTestArgs{
-			expectedName:      "Access to VM via portforward",
+			expectedName:      "Access to VM via portforward: ResponseComplete",
 			customSubresource: "portforward",
 		}),
 		Entry("VM Access with losted VM event should filled without errors", vmAccessTestArgs{
-			expectedName:      "Access to VM via serial console",
+			expectedName:      "Access to VM via serial console: ResponseComplete",
 			customSubresource: "console",
 			shouldLostVM:      true,
 		}),
 		Entry("VM Access with losted VD and Node event should filled without errors", vmAccessTestArgs{
-			expectedName:      "Access to VM via serial console",
+			expectedName:      "Access to VM via serial console: ResponseComplete",
 			customSubresource: "console",
 			shouldLostVD:      true,
 			shouldLostNode:    true,