-
Notifications
You must be signed in to change notification settings - Fork 2
feat: sync tolerations immediately for auto migration when node placement changed #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates component versions to point to a new kubevirt feature branch for immediate toleration sync, adjusts the pod placement comparator to trigger a dynamic placementAction instead of a static restart when tolerations differ, and adds a temporary cache version entry in the werf configuration. Class diagram for updated pod placement comparator logicclassDiagram
class VirtualMachineSpec {
+Tolerations
}
class FieldChange {
+currentValue
+desiredValue
+isEqual
+action
}
class comparator_pod_placement {
+compareTolerations(current: VirtualMachineSpec, desired: VirtualMachineSpec): FieldChange[]
}
VirtualMachineSpec --> comparator_pod_placement : used by
comparator_pod_placement --> FieldChange : returns
FieldChange : action
FieldChange : now set by placementAction() (was ActionRestart)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
b40bf13 to
8520bb0
Compare
8520bb0 to
52cd9b2
Compare
84eb349 to
2666e5b
Compare
Signed-off-by: Yaroslav Borbat <[email protected]>
ed4ca06 to
c4975fd
Compare
Isteb4k
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync tolerations immediately for auto migration when node placement changed.
deckhouse/3p-kubevirt#37
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries