Skip to content

Commit 14589bb

Browse files
dempseyatgithubdempseyatgithub
committed
Update for Xcode 9
- Take suggested compiler warnings - Update to use PRODUCT_BUNDLE_IDENTIFIER build setting
1 parent 35bbbfa commit 14589bb

File tree

3 files changed

+30
-3
lines changed

3 files changed

+30
-3
lines changed

‎BuildSettingExtractor.xcodeproj/project.pbxproj

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@
232232
53719E8719BF4C6D005D3DE0 /* Project object */ = {
233233
isa = PBXProject;
234234
attributes = {
235-
LastUpgradeCheck = 0510;
235+
LastUpgradeCheck = 0900;
236236
ORGANIZATIONNAME = "Tapas Software";
237237
TargetAttributes = {
238238
53719EAF19BF4C6D005D3DE0 = {
@@ -351,18 +351,30 @@
351351
CLANG_CXX_LIBRARY = "libc++";
352352
CLANG_ENABLE_MODULES = YES;
353353
CLANG_ENABLE_OBJC_ARC = YES;
354+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
354355
CLANG_WARN_BOOL_CONVERSION = YES;
356+
CLANG_WARN_COMMA = YES;
355357
CLANG_WARN_CONSTANT_CONVERSION = YES;
356358
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
357359
CLANG_WARN_EMPTY_BODY = YES;
358360
CLANG_WARN_ENUM_CONVERSION = YES;
361+
CLANG_WARN_INFINITE_RECURSION = YES;
359362
CLANG_WARN_INT_CONVERSION = YES;
363+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
364+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
360365
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
366+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
367+
CLANG_WARN_STRICT_PROTOTYPES = YES;
368+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
369+
CLANG_WARN_UNREACHABLE_CODE = YES;
361370
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
362371
COPY_PHASE_STRIP = NO;
372+
ENABLE_STRICT_OBJC_MSGSEND = YES;
373+
ENABLE_TESTABILITY = YES;
363374
GCC_C_LANGUAGE_STANDARD = gnu99;
364375
GCC_DYNAMIC_NO_PIC = NO;
365376
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
377+
GCC_NO_COMMON_BLOCKS = YES;
366378
GCC_OPTIMIZATION_LEVEL = 0;
367379
GCC_PREPROCESSOR_DEFINITIONS = (
368380
"DEBUG=1",
@@ -389,19 +401,30 @@
389401
CLANG_CXX_LIBRARY = "libc++";
390402
CLANG_ENABLE_MODULES = YES;
391403
CLANG_ENABLE_OBJC_ARC = YES;
404+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
392405
CLANG_WARN_BOOL_CONVERSION = YES;
406+
CLANG_WARN_COMMA = YES;
393407
CLANG_WARN_CONSTANT_CONVERSION = YES;
394408
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
395409
CLANG_WARN_EMPTY_BODY = YES;
396410
CLANG_WARN_ENUM_CONVERSION = YES;
411+
CLANG_WARN_INFINITE_RECURSION = YES;
397412
CLANG_WARN_INT_CONVERSION = YES;
413+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
414+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
398415
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
416+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
417+
CLANG_WARN_STRICT_PROTOTYPES = YES;
418+
CLANG_WARN_SUSPICIOUS_MOVE = YES;
419+
CLANG_WARN_UNREACHABLE_CODE = YES;
399420
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
400421
COPY_PHASE_STRIP = YES;
401422
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
402423
ENABLE_NS_ASSERTIONS = NO;
424+
ENABLE_STRICT_OBJC_MSGSEND = YES;
403425
GCC_C_LANGUAGE_STANDARD = gnu99;
404426
GCC_ENABLE_OBJC_EXCEPTIONS = YES;
427+
GCC_NO_COMMON_BLOCKS = YES;
405428
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
406429
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
407430
GCC_WARN_UNDECLARED_SELECTOR = YES;
@@ -421,6 +444,7 @@
421444
GCC_PRECOMPILE_PREFIX_HEADER = YES;
422445
GCC_PREFIX_HEADER = "BuildSettingExtractor/BuildSettingExtractor-Prefix.pch";
423446
INFOPLIST_FILE = "BuildSettingExtractor/BuildSettingExtractor-Info.plist";
447+
PRODUCT_BUNDLE_IDENTIFIER = "net.tapas-software.${PRODUCT_NAME:rfc1034identifier}";
424448
PRODUCT_NAME = "$(TARGET_NAME)";
425449
WRAPPER_EXTENSION = app;
426450
};
@@ -434,6 +458,7 @@
434458
GCC_PRECOMPILE_PREFIX_HEADER = YES;
435459
GCC_PREFIX_HEADER = "BuildSettingExtractor/BuildSettingExtractor-Prefix.pch";
436460
INFOPLIST_FILE = "BuildSettingExtractor/BuildSettingExtractor-Info.plist";
461+
PRODUCT_BUNDLE_IDENTIFIER = "net.tapas-software.${PRODUCT_NAME:rfc1034identifier}";
437462
PRODUCT_NAME = "$(TARGET_NAME)";
438463
WRAPPER_EXTENSION = app;
439464
};
@@ -455,6 +480,7 @@
455480
"$(inherited)",
456481
);
457482
INFOPLIST_FILE = "BuildSettingExtractorTests/BuildSettingExtractorTests-Info.plist";
483+
PRODUCT_BUNDLE_IDENTIFIER = "net.tapas-software.${PRODUCT_NAME:rfc1034identifier}";
458484
PRODUCT_NAME = "$(TARGET_NAME)";
459485
TEST_HOST = "$(BUNDLE_LOADER)";
460486
WRAPPER_EXTENSION = xctest;
@@ -473,6 +499,7 @@
473499
GCC_PRECOMPILE_PREFIX_HEADER = YES;
474500
GCC_PREFIX_HEADER = "BuildSettingExtractor/BuildSettingExtractor-Prefix.pch";
475501
INFOPLIST_FILE = "BuildSettingExtractorTests/BuildSettingExtractorTests-Info.plist";
502+
PRODUCT_BUNDLE_IDENTIFIER = "net.tapas-software.${PRODUCT_NAME:rfc1034identifier}";
476503
PRODUCT_NAME = "$(TARGET_NAME)";
477504
TEST_HOST = "$(BUNDLE_LOADER)";
478505
WRAPPER_EXTENSION = xctest;

‎BuildSettingExtractor/BuildSettingExtractor-Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<key>CFBundleIconFile</key>
1010
<string></string>
1111
<key>CFBundleIdentifier</key>
12-
<string>net.tapas-software.${PRODUCT_NAME:rfc1034identifier}</string>
12+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1313
<key>CFBundleInfoDictionaryVersion</key>
1414
<string>6.0</string>
1515
<key>CFBundleName</key>

‎BuildSettingExtractorTests/BuildSettingExtractorTests-Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<key>CFBundleExecutable</key>
88
<string>${EXECUTABLE_NAME}</string>
99
<key>CFBundleIdentifier</key>
10-
<string>net.tapas-software.${PRODUCT_NAME:rfc1034identifier}</string>
10+
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
1111
<key>CFBundleInfoDictionaryVersion</key>
1212
<string>6.0</string>
1313
<key>CFBundlePackageType</key>

0 commit comments

Comments
 (0)