Remove an atomic op from wait_sync_update

devreal · devreal · commit ca79fa11f6be · 2022-11-22T10:04:29.000-05:00
Signed-off-by: Joseph Schuchart &lt;schuchart@icl.utk.edu&gt;
diff --git a/opal/mca/threads/wait_sync.h b/opal/mca/threads/wait_sync.h
@@ -145,9 +145,10 @@ OPAL_DECLSPEC void opal_threads_base_wait_sync_global_wakeup_mt(int status);
 static inline void wait_sync_update(ompi_wait_sync_t *sync, int updates, int status)
 {
     if (OPAL_LIKELY(OPAL_SUCCESS == status)) {
-        if (0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {
+        if (1 != sync->count && 0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {
             return;
         }
+        sync->count = 0;
     } else {
         /* this is an error path so just use the atomic */
         sync->status = status;

Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,10 @@ OPAL_DECLSPEC void opal_threads_base_wait_sync_global_wakeup_mt(int status);`
`145`	`145`	`static inline void wait_sync_update(ompi_wait_sync_t *sync, int updates, int status)`
`146`	`146`	`{`
`147`	`147`	`if (OPAL_LIKELY(OPAL_SUCCESS == status)) {`
`148`		`- if (0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {`
	`148`	`+ if (1 != sync->count && 0 != (OPAL_THREAD_ADD_FETCH32(&sync->count, -updates))) {`
`149`	`149`	`return;`
`150`	`150`	`}`
	`151`	`+ sync->count = 0;`
`151`	`152`	`} else {`
`152`	`153`	`/* this is an error path so just use the atomic */`
`153`	`154`	`sync->status = status;`