Replace quoting via " in messages by quote_begin and quote_end

This is in the spirit of #4875, but now using quote_begin/quote_end stream
modifiers.

Author: tautschnig

jbmc/regression/jbmc/lambda1/test_goto_functions.desc

@@ -1,14 +1,14 @@
 CORE
 Lambdatest
 --verbosity 10 --show-goto-functions --function Lambdatest.main --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar`
-lambda function reference lambda\$new\$0 in class \"Lambdatest\"
-lambda function reference lambda\$new\$1 in class \"Lambdatest\"
-lambda function reference lambda\$captureReference\$2 in class \"Lambdatest\"
-lambda function reference lambda\$captureInt\$3 in class \"Lambdatest\"
-lambda function reference lambda\$captureThisPrimitive\$4 in class \"Lambdatest\"
-lambda function reference lambda\$captureThisReference\$5 in class \"Lambdatest\"
-lambda function reference lambda\$captureAndCall\$6 in class \"Lambdatest\"
-lambda function reference lambda\$captureAndAssign\$7 in class \"Lambdatest\"
-lambda function reference lambda\$static\$0 in class \"B\"
+lambda function reference lambda\$new\$0 in class 'Lambdatest'
+lambda function reference lambda\$new\$1 in class 'Lambdatest'
+lambda function reference lambda\$captureReference\$2 in class 'Lambdatest'
+lambda function reference lambda\$captureInt\$3 in class 'Lambdatest'
+lambda function reference lambda\$captureThisPrimitive\$4 in class 'Lambdatest'
+lambda function reference lambda\$captureThisReference\$5 in class 'Lambdatest'
+lambda function reference lambda\$captureAndCall\$6 in class 'Lambdatest'
+lambda function reference lambda\$captureAndAssign\$7 in class 'Lambdatest'
+lambda function reference lambda\$static\$0 in class 'B'
 ^EXIT=0$
 ^SIGNAL=0$

jbmc/regression/jbmc/lambda2/test.desc

@@ -1,7 +1,7 @@
 CORE symex-driven-lazy-loading-expected-failure
 org.symphonyoss.symphony.clients.model.SymStream
 --show-goto-functions --verbosity 10
-lambda function reference toSymUser in class "org\.symphonyoss\.symphony\.clients\.model\.SymStream"
+lambda function reference toSymUser in class 'org\.symphonyoss\.symphony\.clients\.model\.SymStream'
 ^EXIT=0$
 ^SIGNAL=0$
 --

jbmc/src/java_bytecode/java_bytecode_parser.cpp

@@ -2089,8 +2089,8 @@ void java_bytecode_parsert::read_bootstrapmethods_entry()
     debug() << "lambda function reference "
             << id2string(lambda_method_handle->get_method_descriptor()
                            .base_method_name())
-            << " in class \"" << parse_tree.parsed_class.name << "\""
-            << "\n  interface type is "
+            << " in class " << quote_begin << parse_tree.parsed_class.name
+            << quote_end << "\n  interface type is "
             << id2string(pool_entry(interface_type_argument.ref1).s)
             << "\n  method type is "
             << id2string(pool_entry(method_type_argument.ref1).s) << eom;

src/cpp/cpp_typecheck_function.cpp

@@ -59,8 +59,8 @@ void cpp_typecheckt::convert_parameter(
   if(symbol_table.move(symbol, new_symbol))
   {
     error().source_location=symbol.location;
-    error() << "cpp_typecheckt::convert_parameter: symbol_table.move(\""
-            << symbol.name << "\") failed" << eom;
+    error() << "cpp_typecheckt::convert_parameter: symbol_table.move("
+            << quote_begin << symbol.name << quote_end << ") failed" << eom;
     throw 0;
   }
 

src/goto-analyzer/taint_parser.cpp

@@ -64,9 +64,13 @@ bool taint_parser(
     else
     {
       messaget message(message_handler);
-      message.error() << "taint rule must have \"kind\" which is "
-                         "\"source\" or \"sink\" or \"sanitizer\""
-                      << messaget::eom;
+      message.error() << "taint rule must have " << messaget::quote_begin
+                      << "kind" << messaget::quote_end << " which is "
+                      << messaget::quote_begin << "source"
+                      << messaget::quote_end << " or " << messaget::quote_begin
+                      << "sink" << messaget::quote_end << " or "
+                      << messaget::quote_begin << "sanitizer"
+                      << messaget::quote_end << messaget::eom;
       return true;
     }
 
@@ -75,8 +79,8 @@ bool taint_parser(
     if(function.empty())
     {
       messaget message(message_handler);
-      message.error() << "taint rule must have \"function\""
-                      << messaget::eom;
+      message.error() << "taint rule must have " << messaget::quote_begin
+                      << "function" << messaget::quote_end << messaget::eom;
       return true;
     }
     else
@@ -101,10 +105,13 @@ bool taint_parser(
     else
     {
       messaget message(message_handler);
-      message.error() << "taint rule must have \"where\""
-                      << " which is \"return_value\" or \"this\" "
-                      << "or \"parameter1\"..."
-                      << messaget::eom;
+      message.error() << "taint rule must have " << messaget::quote_begin
+                      << "where" << messaget::quote_end << " which is "
+                      << messaget::quote_begin << "return_value"
+                      << messaget::quote_end << " or " << messaget::quote_begin
+                      << "this" << messaget::quote_end << " or "
+                      << messaget::quote_begin << "parameter1"
+                      << messaget::quote_end << "..." << messaget::eom;
       return true;
     }
 

src/linking/linking.cpp

@@ -402,9 +402,8 @@ void linkingt::link_warning(
 {
   warning().source_location=new_symbol.location;
 
-  warning() << "warning: " << msg << " \""
-            << old_symbol.display_name()
-            << "\"" << '\n';
+  warning() << "warning: " << msg << " " << quote_begin
+            << old_symbol.display_name() << quote_end << '\n';
   warning() << "old definition in module " << old_symbol.module << " "
             << old_symbol.location << '\n'
             << type_to_string_verbose(old_symbol) << '\n';
@@ -1060,7 +1059,8 @@ void linkingt::duplicate_object_symbol(
         warning().source_location=new_symbol.location;
 
         warning() << "warning: conflicting initializers for"
-                  << " variable \"" << old_symbol.name << "\"\n";
+                  << " variable " << quote_begin << old_symbol.name << quote_end
+                  << '\n';
         warning() << "using old value in module " << old_symbol.module << " "
                   << old_symbol.value.find_source_location() << '\n'
                   << expr_to_string(old_symbol.name, tmp_old) << '\n';

src/solvers/smt2/smt2_dec.cpp

@@ -181,8 +181,8 @@ decision_proceduret::resultt smt2_dect::read_result(std::istream &in)
       {
         messaget log{message_handler};
         log.error() << "SMT2 solver returned error message:\n"
-                    << "\t\"" << parsed.get_sub()[1].id() << "\""
-                    << messaget::eom;
+                    << "\t" << messaget::quote_begin << parsed.get_sub()[1].id()
+                    << messaget::quote_end << messaget::eom;
         return decision_proceduret::resultt::D_ERROR;
       }
     }

src/solvers/strings/string_refinement.cpp

@@ -1093,8 +1093,9 @@ static exprt get_char_array_and_concretize(
         const auto array_expr =
           expr_try_dynamic_cast<array_exprt>(*concretized_array))
       {
-        stream << std::string(4, ' ') << "- as_string: \""
-               << string_of_array(*array_expr) << "\"\n";
+        stream << std::string(4, ' ')
+               << "- as_string: " << messaget::quote_begin
+               << string_of_array(*array_expr) << messaget::quote_end << '\n';
       }
       else
         stream << std::string(2, ' ') << "- warning: not an array"