Handle expired credentials in createPresentation

[alexfigtree]

Issue originally found on LCW: Create Share Link Isn't Possible for Credentials with Warnings #742

Share links can't be created on LCWs for VC's that are expired. There is a call on the LCW side for vc.createPresentation - Failure to create a public link on LCW for the "certified-safe-4-agilist.png" credential appears to be coming from app/lib/present.ts on this line:

const presentation = vc.createPresentation({ verifiableCredential, holder })

Also possibly related to VC's throwing an exception when cred is expired: digitalcredentials/vc#27

[jchartrand]

This isn't a bug, and it isn't something caused by verifier-core.

It is that the LCW needs a VerifiablePresentation to pass to verifierPlus, and so uses the @digitalcredentials/vc library to construct the verifiablePresentation, i.e, the vc.createPresentation call.

But, the vc.createPresentation call won't, by design, create a presentation if any of the credentials passed in don't verify.

So, we need to modify vc.createPresentation to allow for creating a presentation even if one of the VCs doesn't verify.

[jchartrand]

It is also not related to digitalcredentials/vc#27 which is a different issue to do with what the vc library was returning and how it affected LCW, but that has effectively been dealt with verifier-core.

[alexfigtree]

Closing this in favor of issue in vc repo: digitalcredentials/vc#32