DEV: Fix test failures and an incompatibility with reactions (#234)

Author: pmusaraj

app/models/concerns/discourse_activity_pub/a_p/model_callbacks.rb

@@ -91,6 +91,8 @@ def performing_activity_object
               end
               self.build_activity_pub_object(attrs)
             when :undo
+              return nil if !self.activity_pub_object.present?
+
               activity_pub_actor
                 .activities
                 .where(object_id: self.activity_pub_object.id)

assets/javascripts/discourse/routes/activity-pub-actor-followers.js

@@ -5,6 +5,7 @@ import ActivityPubActor from "../models/activity-pub-actor";
 
 export default class ActivityPubActorFollowers extends DiscourseRoute {
   @service site;
+  @service router;
 
   queryParams = {
     order: { refreshModel: true },

spec/requests/admin/discourse_activity_pub/actor_controller_spec.rb

@@ -21,7 +21,7 @@ def actor_warning(key)
         get "/admin/plugins/ap/actor.json"
         expect(response.status).to eq(400)
         expect(response.parsed_body["errors"]).to include(
-          "param is missing or the value is empty: model_type",
+          "param is missing or the value is empty or invalid: model_type",
         )
       end
     end

spec/requests/discourse_activity_pub/authorization_controller_spec.rb

@@ -71,7 +71,7 @@
         post "/ap/auth/verify"
         expect(response.status).to eq(400)
         expect(response.parsed_body["errors"].first).to include(
-          "param is missing or the value is empty: domain",
+          "param is missing or the value is empty or invalid: domain",
         )
       end
     end
@@ -81,7 +81,7 @@
         post "/ap/auth/verify", params: { domain: external_domain1 }
         expect(response.status).to eq(400)
         expect(response.parsed_body["errors"].first).to include(
-          "param is missing or the value is empty: auth_type",
+          "param is missing or the value is empty or invalid: auth_type",
         )
       end
     end