DEV: Don't use string-based actions (#237)

Author: CvX

assets/javascripts/discourse/components/activity-pub-actor-admin-row.gjs

@@ -37,9 +37,9 @@ export default class ActivityPubActorAdminRow extends Component {
   }
 
   @action
-  editActor(actor) {
+  editActor() {
     this.router
-      .transitionTo("adminPlugins.activityPub.actorShow", actor)
+      .transitionTo("adminPlugins.activityPub.actorShow", this.actor)
       .then(() => {
         this.actorShowController.set("showForm", true);
       });
@@ -102,15 +102,15 @@ export default class ActivityPubActorAdminRow extends Component {
       <div class="directory-table__cell activity-pub-actor-table-actions">
         {{#if this.actor.isDeleted}}
           <DButton
-            @action={{action "destroyActor"}}
+            @action={{this.destroyActor}}
             @label="admin.discourse_activity_pub.actor.destroy.label"
             @title="admin.discourse_activity_pub.actor.destroy.title"
             @icon="trash-can"
             class="activity-pub-destroy-actor-btn btn-danger"
             @disabled={{this.loading}}
           />
           <DButton
-            @action={{action "restoreActor"}}
+            @action={{this.restoreActor}}
             @label="admin.discourse_activity_pub.actor.restore.label"
             @title="admin.discourse_activity_pub.actor.restore.title"
             @icon="arrow-rotate-left"
@@ -119,7 +119,7 @@ export default class ActivityPubActorAdminRow extends Component {
           />
         {{else}}
           <DButton
-            @action={{action "editActor" this.actor}}
+            @action={{this.editActor}}
             @label="admin.discourse_activity_pub.actor.edit.label"
             @title="admin.discourse_activity_pub.actor.edit.title"
             @icon="pencil"

assets/javascripts/discourse/components/activity-pub-authorize.gjs

@@ -146,7 +146,7 @@ export default class ActivityPubAuthorize extends Component {
             <span>{{this.domain}}</span>
             <DButton
               @icon="xmark"
-              @action={{action "clearDomain"}}
+              @action={{this.clearDomain}}
               @title="user.discourse_activity_pub.clear_domain_button.title"
               id="user_activity_pub_authorize_clear_domain"
               class="activity-pub-authorize-clear-domain"
@@ -163,7 +163,7 @@ export default class ActivityPubAuthorize extends Component {
         {{/if}}
         <DButton
           @icon="check"
-          @action={{action "verifyDomain"}}
+          @action={{this.verifyDomain}}
           @label="user.discourse_activity_pub.verify_domain_button.label"
           @title="user.discourse_activity_pub.verify_domain_button.title"
           @disabled={{this.verifyDisabled}}
@@ -172,7 +172,7 @@ export default class ActivityPubAuthorize extends Component {
         />
         <DButton
           @icon="fingerprint"
-          @action={{action "authorizeDomain"}}
+          @action={{this.authorizeDomain}}
           @label="user.discourse_activity_pub.authorize_button.label"
           @title="user.discourse_activity_pub.authorize_button.title"
           @disabled={{this.authorizeDisabled}}

assets/javascripts/discourse/components/activity-pub-follow-domain.gjs

@@ -103,7 +103,7 @@ export default class ActivityPubFollowDomain extends Component {
         />
         <DButton
           @icon="up-right-from-square"
-          @action={{action "follow"}}
+          @action={{this.follow}}
           @label="discourse_activity_pub.follow.domain.btn_label"
           @title="discourse_activity_pub.follow.domain.btn_title"
           @disabled={{this.verifying}}

assets/javascripts/discourse/components/modal/activity-pub-actor-follow.gjs

@@ -105,7 +105,7 @@ export default class ActivityPubFollowRemote extends Component {
               />
               <DButton
                 @icon="magnifying-glass"
-                @action={{action "find"}}
+                @action={{this.find}}
                 @label="discourse_activity_pub.actor_follow.find.btn_label"
                 @title="discourse_activity_pub.actor_follow.find.btn_title"
                 @disabled={{this.validating}}
@@ -129,7 +129,7 @@ export default class ActivityPubFollowRemote extends Component {
                 <ActivityPubActorFollowBtn
                   @actor={{@model.actor}}
                   @followActor={{this.followActor}}
-                  @follow={{action "follow"}}
+                  @follow={{this.follow}}
                 />
               </div>
             {{else if this.finding}}

assets/javascripts/discourse/components/modal/activity-pub-actor-reject.gjs

@@ -37,7 +37,7 @@ export default class ActivityPubActorReject extends Component {
 
       <:footer>
         <DButton
-          @action={{action "reject"}}
+          @action={{this.reject}}
           @label="discourse_activity_pub.actor_reject.label"
           class="btn-primary"
         />

assets/javascripts/discourse/components/modal/activity-pub-actor-unfollow.gjs

@@ -37,7 +37,7 @@ export default class ActivityPubActorUnfollow extends Component {
 
       <:footer>
         <DButton
-          @action={{action "unfollow"}}
+          @action={{this.unfollow}}
           @label="discourse_activity_pub.actor_unfollow.label"
           class="btn-primary"
         />