Move RegisterSigner to BatchPoster (EspressoSystems#691)

* dont register signer if dataposter is less than onchain

* fixes

* dont send tx if dataposter is ahead of on chain

* cleanup

* address comments

Author: lukeiannucci

arbnode/batch_poster.go

@@ -1918,7 +1918,11 @@ func (b *BatchPoster) MaybePostSequencerBatch(ctx context.Context) (bool, error)
 	if espressoSubmitter := b.streamer.espressoSubmitter; espressoSubmitter != nil {
 		registered := espressoSubmitter.GetKeyManager().HasRegistered()
 		if !registered {
-			return false, fmt.Errorf("ephemeral keys are not yet registered in Espresso TEE Contract")
+			log.Warn("ephemeral keys are not yet registered in Espresso TEE Contract")
+			err := espressoSubmitter.RegisterSigner()
+			if err != nil {
+				return false, fmt.Errorf("unable to register signer: %w", err)
+			}
 		}
 	}
 

espresso/submitter/polling_espresso_submitter.go

@@ -704,12 +704,7 @@ func (s *PollingEspressoSubmitter) RegisterSigner() error {
 
 func (s *PollingEspressoSubmitter) Start(sw *stopwaiter.StopWaiter) error {
 	if s.lightClientReader != nil && s.espressoClient != nil {
-		err := s.RegisterSigner()
-		if err != nil {
-			log.Error("failed to register espresso key manager", "err", err)
-			return err
-		}
-		err = stopwaiter.CallIterativelyWith[struct{}](sw, s.pollSubmittedTransactionForFinality, nil)
+		err := stopwaiter.CallIterativelyWith[struct{}](sw, s.pollSubmittedTransactionForFinality, nil)
 		if err != nil {
 			return err
 		}

espresso/submitter/submitter.go

@@ -24,6 +24,7 @@ type EspressoSubmitter interface {
 	Start(sw *stopwaiter.StopWaiter) error
 	NotifyNewPendingMessages(pos arbutil.MessageIndex, messages []arbostypes.MessageWithMetadataAndBlockInfo) error
 	GetKeyManager() espresso_key_manager.EspressoKeyManagerInterface
+	RegisterSigner() error
 
 	IsEscapeHatchEnabled() bool
 	GetLastConfirmedPosition() (*arbutil.MessageIndex, error)

espressotee/espresso_tee_helpers.go

@@ -1,14 +1,18 @@
 package espressotee
 
 import (
+	"context"
 	"fmt"
 	"math/big"
 	"strings"
 	"time"
 
 	"github.com/spf13/pflag"
 
+	"github.com/ethereum/go-ethereum/ethclient"
 	"github.com/ethereum/go-ethereum/log"
+
+	"github.com/offchainlabs/nitro/arbnode/dataposter"
 )
 
 type TEE uint8
@@ -99,6 +103,30 @@ func BaseFeeCheck(
 	return nil
 }
 
+/**
+ * This functions checks the dataposter nonce and the parent chains nonce
+ * If these two differ, dont send a transaction as registering the signer is costly and we dont want to send multiple transactions.
+ * This will constantly be called when we try and post a batch which will allow time for the two to eventually sync up.
+ */
+func NonceValidation(context context.Context, l1Client *ethclient.Client, dataPoster *dataposter.DataPoster) error {
+	nonce, err := l1Client.NonceAt(context, dataPoster.Sender(), nil)
+	if err != nil {
+		log.Warn("could not retrieve on-chain nonce", "err", err)
+		return err
+	}
+	dataPosterNonce, _, err := dataPoster.GetNextNonceAndMeta(context)
+	if err != nil {
+		log.Warn("error getting dataposter nonce", "err", err)
+		return err
+	}
+	log.Info("successfully got datapaster next nonce and on-chain nonce", "dataposter nonce", dataPosterNonce, "on-chain nonce", nonce)
+	if dataPosterNonce != nonce {
+		log.Warn("dataposter and on-chain nonce have mismatch, not sending txn", "dataposter nonce", dataPosterNonce, "on-chain nonce", nonce)
+		return err
+	}
+	return nil
+}
+
 type EspressoRegisterSignerConfig struct {
 	MaxTxnWaitTime                time.Duration `koanf:"max-txn-wait-time"`
 	RetryBaseFeeDelay             time.Duration `koanf:"retry-base-fee-delay"`

espressotee/espresso_verifier.go

@@ -84,13 +84,10 @@ func (e *EspressoTEEVerifier) RegisterSigner(
 	if err != nil {
 		return err
 	}
-	nonce, err := e.l1Client.NonceAt(context.Background(), dataPoster.Sender(), nil)
-	if err == nil {
-		log.Info("registering signer: on chain nonce", "nonce", nonce)
-	}
-	dataPosterNonce, _, err := dataPoster.GetNextNonceAndMeta(context.Background())
-	if err == nil {
-		log.Info("registering signer: dataposter next nonce", "nonce", dataPosterNonce)
+
+	err = NonceValidation(context.Background(), e.l1Client, dataPoster)
+	if err != nil {
+		return err
 	}
 	// Add a buffer to the estimate for the gas limit
 	gasLimit := estimate * (100 + registerSignerOpts.GasLimitBufferIncreasePercent) / 100

espressotee/nitro_verifier.go

@@ -91,13 +91,9 @@ func (e *EspressoNitroTEEVerifier) VerifyCert(
 	if err != nil {
 		return certHash, err
 	}
-	nonce, err := e.l1Client.NonceAt(context.Background(), dataPoster.Sender(), nil)
-	if err == nil {
-		log.Info("verify cert: on chain nonce", "nonce", nonce)
-	}
-	dataPosterNonce, _, err := dataPoster.GetNextNonceAndMeta(context.Background())
-	if err == nil {
-		log.Info("verify cert: dataposter next nonce", "nonce", dataPosterNonce)
+	err = NonceValidation(context.Background(), e.l1Client, dataPoster)
+	if err != nil {
+		return certHash, err
 	}
 	// Add a buffer to the estimate for the gas limit
 	gasLimit := estimate * (100 + registerSignerOpts.GasLimitBufferIncreasePercent) / 100