allows to disable lake formation

rudolfix · rudolfix · commit 14cca2dece21 · 2025-11-14T20:02:13.000+01:00
diff --git a/dlt/destinations/impl/athena/athena.py b/dlt/destinations/impl/athena/athena.py
@@ -348,6 +348,7 @@ def update_stored_schema(
         if (
             self.config.lakeformation_config is not None
             and self.config.lakeformation_config.enabled
+            is not None  # both True and False are actionable
         ):
             self.manage_lf_tags()
         return applied_update
diff --git a/dlt/destinations/impl/athena/configuration.py b/dlt/destinations/impl/athena/configuration.py
@@ -8,7 +8,7 @@
 
 @configspec
 class LakeformationConfig:
-    enabled: bool = False
+    enabled: Optional[bool] = None
     tags: Optional[Dict[str, str]] = None
 
 
diff --git a/tests/load/athena_iceberg/test_lakeformation.py b/tests/load/athena_iceberg/test_lakeformation.py
@@ -186,7 +186,9 @@ def create_pipelines(
     )
     lf_disabled_pipeline = destination_config.setup_pipeline(
         pipeline_name,
-        destination=destination_config.destination_factory(),
+        destination=destination_config.destination_factory(
+            lakeformation_config=LakeformationConfig(enabled=False)
+        ),
         dataset_name=dataset_name,
         staging=staging_destination,
     )

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,9 @@ def create_pipelines(`
`186`	`186`	`)`
`187`	`187`	`lf_disabled_pipeline = destination_config.setup_pipeline(`
`188`	`188`	`pipeline_name,`
`189`		`- destination=destination_config.destination_factory(),`
	`189`	`+ destination=destination_config.destination_factory(`
	`190`	`+ lakeformation_config=LakeformationConfig(enabled=False)`
	`191`	`+ ),`
`190`	`192`	`dataset_name=dataset_name,`
`191`	`193`	`staging=staging_destination,`
`192`	`194`	`)`