Skip to content

fix: Process anonymous fields in libvirt XML #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Process anonymous fields in libvirt XML #1222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions internal/codegen/parser/libvirtxml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ func (r *LibvirtXMLReflector) ReflectStruct(structType reflect.Type) (*generator
continue
}

if field.Anonymous {
if field.Type.Kind() == reflect.Struct {
embeddedIR, err := r.ReflectStruct(field.Type)
if err != nil {
return nil, fmt.Errorf("analyzing embedded struct %s: %w", field.Type.Name(), err)
}
ir.Fields = append(ir.Fields, embeddedIR.Fields...)
}
continue
}

fieldIR, err := r.analyzeField(typeName, field)
if err != nil {
return nil, fmt.Errorf("analyzing field %s: %w", field.Name, err)
Expand Down Expand Up @@ -248,11 +259,6 @@ func (r *LibvirtXMLReflector) analyzeField(structName string, field reflect.Stru
return nil, nil
}

// Skip embedded/anonymous fields
if field.Anonymous {
return nil, nil
}

xmlTag := field.Tag.Get("xml")
if xmlTag == "" {
// Skip fields without XML tags
Expand Down