Skip to content

Commit 38ea2e0

Browse files
committed
implement TODOs
1 parent d881eca commit 38ea2e0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/postload.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ ig.module('readable-saves')
7575
},
7676
});
7777

78-
// TODO: explain why I don't use backups
79-
8078
ig.StorageDataReadable = ig.Class.extend({
8179
loaded: false,
8280
cacheType: 'StorageDataReadable',
@@ -207,7 +205,13 @@ ig.module('readable-saves')
207205
},
208206

209207
async _writeToDir(rootDir, data) {
210-
// TODO: explain file modes
208+
// You know, while writing this I thought of setting file
209+
// modes/permissions on the save file correctly. Good UNIX citizens
210+
// usually set 600 (rw-------) permissions on private files and
211+
// CrossCode savegame can be considered a private file, but since the
212+
// stock game doesn't do that already and I doubt that many people play
213+
// CrossCode on multi-user UNIX setups, I believe that this is
214+
// unnecessary (at least for the time being).
211215

212216
// first of all, create the directory structure in the correct order
213217
await mkdirIfNotExists(rootDir);

0 commit comments

Comments
 (0)