Cleanup.

Author: trivialfis

include/xgboost/c_api.h

@@ -1333,21 +1333,23 @@ XGB_DLL int XGBoosterPredictFromCudaColumnar(BoosterHandle handle, char const *d
  * @{
  */
 
-/*!
- * \brief Load model from existing file
+/**
+ * @brief Load the model from an existing file
  *
- * \param handle handle
- * \param fname File URI or file name. The string must be UTF-8 encoded.
- * \return 0 when success, -1 when failure happens
+ * @param handle handle
+ * @param fname File name. The string must be UTF-8 encoded.
+ *
+ * @return 0 when success, -1 when failure happens
  */
 XGB_DLL int XGBoosterLoadModel(BoosterHandle handle,
                                const char *fname);
-/*!
- * \brief Save model into existing file
+/**
+ * @brief Save the model into an existing file
  *
- * \param handle handle
- * \param fname File URI or file name. The string must be UTF-8 encoded.
- * \return 0 when success, -1 when failure happens
+ * @param handle handle
+ * @param fname File name. The string must be UTF-8 encoded.
+ *
+ * @return 0 when success, -1 when failure happens
  */
 XGB_DLL int XGBoosterSaveModel(BoosterHandle handle,
                                const char *fname);

src/c_api/c_api.cc

@@ -1493,9 +1493,10 @@ XGB_DLL int XGBoosterSaveModel(BoosterHandle handle, const char *fname) {
     Json::Dump(out, &str, mode);
     fo->Write(str.data(), str.size());
   };
-  if (common::FileExtension(fname) == "json") {
+  auto ext = common::FileExtension(fname);
+  if (ext == "json") {
     save_json(std::ios::out);
-  } else if (common::FileExtension(fname) == "ubj") {
+  } else if (ext == "ubj") {
     save_json(std::ios::binary);
   } else {
     LOG(WARNING) << "Saving model in the UBJSON format as default.  You can use file extension:"