onChange doesn't fire

[jeromevvb]

Hello guys,

Hope you're doing well.
Thanks for this nice component!

I just download this library and started to use but i realized a problem with the onChange method.
My method setDatetime is not called :(

<DateTimePicker DatePicker={DatePickerDialog} TimePicker={TimePickerDialog} onChange={this.setDatetime} />

setDatetime = (datetime) => { console.log(datetime); }

Any errors in the console..
What happened?

i looked the material-ui-datepicker code and i saw you tried to fire up the onChange method inside SelectTime function but you the prop "onAccept" on material-ui timepicker but this props doesnt exist right?
Please let me know if am doing something wrong!
Thaaaaaaank you!!

[dmtrKovalenko]

Oh god)
I just little forgot about this project :sorry:
I will try to fix that asap

[alilland]

experiencing the same issue :)

[dmtrKovalenko]

That was just strange)
I republished previous build, try to install 1.0.4 and let me know if it was not fixed

[ThanksAndShareOffice]

still the same issue =( @dmtrKovalenko

[dmtrKovalenko]

So now I cannot fastly figure out whats going wrong. And I would not have time to look at that deeply near time, so if someone's facing issue and wanna open PR to fix it - you are welcome.

[golya]

@dmtrKovalenko I sent a pull request for this issue. I just removed the setState callback as a hotfix, as it works at selectDate as well. Later we can figure out why the setState callback does not work.

[AleVul]

@golya react version may be the cause of the callback bug.
@dmtrKovalenko could you update the npm repository with the latest changes? it is still on the 1.0.4 version and using setState with the callback

[dmtrKovalenko]

I have. 1.0.5 is already available

[mkozjak]

It doesn't fix it for me.

[jacobbeasley]

Seems to be fixed in 1.0.6