From 8c5923e6470342f2fe038ff4a40a723e97ea27b5 Mon Sep 17 00:00:00 2001 From: Jonathan Woodell Date: Wed, 6 Apr 2022 10:58:55 -0500 Subject: [PATCH 1/2] Add Stop Grace Period to compatibility file. This is already supported downstream but the compatibility file stops it. --- ecs/compatibility.go | 1 + 1 file changed, 1 insertion(+) diff --git a/ecs/compatibility.go b/ecs/compatibility.go index 146d01b06..714885f3e 100644 --- a/ecs/compatibility.go +++ b/ecs/compatibility.go @@ -95,6 +95,7 @@ var compatibleComposeAttributes = []string{ "services.secrets", "services.secrets.source", "services.secrets.target", + "services.stop_grace_period", "services.user", "services.volumes", "services.volumes.read_only", From 90f31d7f2e7e826dba6df57b5125d36b19080673 Mon Sep 17 00:00:00 2001 From: Jonathan Woodell Date: Wed, 6 Apr 2022 13:56:00 -0500 Subject: [PATCH 2/2] Update docs --- docs/ecs-compose-features.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/ecs-compose-features.md b/docs/ecs-compose-features.md index 17aced963..38f5da1b8 100644 --- a/docs/ecs-compose-features.md +++ b/docs/ecs-compose-features.md @@ -55,7 +55,7 @@ __Legend:__ | service.hostname | x | | service.image | ✓ | Private images will be accessible by passing x-aws-pull_policy with ARN of a username+password secret | service.isolation | x | -| service.labels | x | +| service.labels | ✓ | | service.links | x | | service.logging | ✓ | Can be used to customize CloudWatch Logs configuration | service.network_mode | x | @@ -64,7 +64,7 @@ __Legend:__ | service.ports | ✓ | Only symetrical port mapping is supported in ECS. See [Exposing ports](#exposing-ports). | service.secrets | ✓ | See [Secrets](#secrets). | service.security_opt | x | -| service.stop_grace_period | x | +| service.stop_grace_period | ✓ | | service.stop_signal | x | | service.sysctls | x | | service.ulimits | ✓ | Only support `nofile` ulimit due to Fargate limitations