refactor: make enterprise feature additive per Rust conventions (#80)

## Changes

Refactored the `community` and `enterprise` features to follow Rust's
requirement that cfg flags must be additive.

- **Removed** `community` feature - community edition is now the default
- **Kept** `enterprise` feature as an additive flag that enables
enterprise-only APIs
- Updated build.rs, CI workflows, and documentation accordingly

## Motivation

Previously, `community` and `enterprise` were mutually exclusive (XOR
enforcement), which violates Rust's cfg additivity rules. Since
enterprise edition is a strict superset of community (adds encryption,
P2P replication, etc.), it should be modeled as an additive feature.

## Usage

```shell
cargo build                      # Community edition (default)
cargo build --features=enterprise # Enterprise edition
```

All existing `#[cfg(feature = "enterprise")]` guards remain unchanged -
they correctly gate enterprise-only functionality.

Co-authored-by: Claude <[email protected]>

Author: Nao-ris

.cargo-husky/hooks/pre-commit

@@ -1,6 +1,6 @@
 #!/bin/sh -xe
 
-cargo clippy --features=community -- -D warnings
+cargo clippy -- -D warnings
 cargo clippy --features=enterprise -- -D warnings
 
 # Check fmt (protip: run 'cargo fmt --all -- --emit files' to apply format locally)

.github/workflows/build.yml

@@ -12,10 +12,15 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        version: [community, enterprise]
+        edition: [community, enterprise]
+        include:
+          - edition: community
+            cargo_flags: ""
+          - edition: enterprise
+            cargo_flags: "--features=enterprise"
     steps:
       - name: Install apt-get
         run: sudo apt-get install -y clang llvm
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
       - name: Build
-        run: cargo build --features=${{ matrix.version }} --verbose
+        run: cargo build ${{ matrix.cargo_flags }} --verbose

.github/workflows/clippy.yml

@@ -10,7 +10,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        version: [community, enterprise]
+        edition: [community, enterprise]
+        include:
+          - edition: community
+            cargo_flags: ""
+          - edition: enterprise
+            cargo_flags: "--features=enterprise"
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
 
@@ -29,4 +34,4 @@ jobs:
         shell: bash
         run: |
           # shellcheck disable=SC2046
-          cargo clippy --color always --features=${{ matrix.version }}
+          cargo clippy --color always ${{ matrix.cargo_flags }}

.github/workflows/test.yml

@@ -12,7 +12,12 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        version: [community, enterprise]
+        edition: [community, enterprise]
+        include:
+          - edition: community
+            cargo_flags: ""
+          - edition: enterprise
+            cargo_flags: "--features=enterprise"
     steps:
       - name: Install apt-get
         run: sudo apt-get install -y clang llvm
@@ -23,8 +28,8 @@ jobs:
             components: rustfmt, clippy
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
       - name: Run tests
-        run: cargo test --features=${{ matrix.version }} --verbose
+        run: cargo test ${{ matrix.cargo_flags }} --verbose
       - name: Run tests with Couchbase Lite C leak check
-        run: LEAK_CHECK=y cargo test --features=${{ matrix.version }} --verbose -- --test-threads 1
+        run: LEAK_CHECK=y cargo test ${{ matrix.cargo_flags }} --verbose -- --test-threads 1
       - name: Run tests (with address sanitizer)
-        run: LSAN_OPTIONS=suppressions=san.supp RUSTFLAGS="-Zsanitizer=address" cargo +nightly test --target x86_64-unknown-linux-gnu --features=${{ matrix.version }} --verbose
+        run: LSAN_OPTIONS=suppressions=san.supp RUSTFLAGS="-Zsanitizer=address" cargo +nightly test --target x86_64-unknown-linux-gnu ${{ matrix.cargo_flags }} --verbose

Cargo.toml

@@ -47,7 +47,11 @@ incremental = false
 # See: https://github.com/johnthagen/min-sized-rust
 
 [features]
-community = []
+# Enable this feature for Enterprise edition capabilities:
+# - Database encryption
+# - P2P replication (local database endpoints)
+# - Document property encryption/decryption during replication
+# - TLS identity management
 enterprise = []
 
 unsafe-threads-test = []

README.md

@@ -20,19 +20,25 @@ Installation instructions are [here][BINDGEN_INSTALL].
 
 ### 2. Build!
 
-There two different editions of Couchbase Lite C: community & enterprise.
+There are two different editions of Couchbase Lite C: community & enterprise.
 You can find the differences [here][CBL_EDITIONS_DIFF].
 
-When building or declaring this repository as a dependency, you need to specify the edition through a cargo feature:
+**By default, the community edition is used.** To enable enterprise features, use the `enterprise` cargo feature:
 
 ```shell
-$ cargo build --features=community
+$ cargo build  # Uses community edition
 ```
 
 ```shell
-$ cargo build --features=enterprise
+$ cargo build --features=enterprise  # Uses enterprise edition
 ```
 
+The enterprise feature is additive and provides additional capabilities:
+- Database encryption
+- P2P replication (local database endpoints)
+- Document property encryption/decryption during replication
+- TLS identity management
+
 ## Maintaining
 
 ### Couchbase Lite For C
@@ -70,14 +76,15 @@ New C features should also be added to the Rust API at some point.
 ### Test
 
 Tests can be found in the `tests` subdirectory.
-Test are run in the GitHub wrokflow `Test`. You can find the commands used there.
+Tests are run in the GitHub workflow `Test`. You can find the commands used there.
 
 There are three variations:
 
 ### Nominal run
 
 ```shell
-$ cargo test --features=enterprise
+$ cargo test  # Tests community edition
+$ cargo test --features=enterprise  # Tests enterprise edition
 ```
 
 ### Run with Couchbase Lite C leak check
@@ -90,6 +97,7 @@ If this step fails in one of your pull requests, you should look into the `take_
 - `reference` just references the pointer, it will increase the ref count of CBL pointers so releasing it will not free the pointer
 
 ```shell
+$ LEAK_CHECK=y cargo test -- --test-threads 1
 $ LEAK_CHECK=y cargo test --features=enterprise -- --test-threads 1
 ```
 

build.rs

@@ -22,15 +22,6 @@
 // - https://rust-lang.github.io/rust-bindgen/tutorial-3.html
 // - https://doc.rust-lang.org/cargo/reference/build-scripts.html
 
-#[cfg(all(not(feature = "community"), not(feature = "enterprise")))]
-compile_error!(
-    "You need to have at least one the following features activated: community, enterprise"
-);
-#[cfg(all(feature = "community", feature = "enterprise"))]
-compile_error!(
-    "You need to have at most one the following features activated: community, enterprise"
-);
-
 extern crate bindgen;
 extern crate fs_extra;
 
@@ -41,12 +32,12 @@ use std::path::PathBuf;
 use std::process::Command;
 use fs_extra::dir;
 
-#[cfg(feature = "community")]
+#[cfg(not(feature = "enterprise"))]
 static CBL_INCLUDE_DIR: &str = "libcblite_community/include";
 #[cfg(feature = "enterprise")]
 static CBL_INCLUDE_DIR: &str = "libcblite_enterprise/include";
 
-#[cfg(feature = "community")]
+#[cfg(not(feature = "enterprise"))]
 static CBL_LIB_DIR: &str = "libcblite_community/lib";
 #[cfg(feature = "enterprise")]
 static CBL_LIB_DIR: &str = "libcblite_enterprise/lib";