Edit button with latest Firefox due to e10s

[HappyTetrahedron]

In Firefox Nightly (Version 51.0), when e10s is enabled (preferences > general > enable multi-process Nightly), the edit button does not appear when first opening a webpage. To make it appear, I need to switch to a different tab and then switch back.

The keyboard shortcut doesn't work either until I switch back and forth between tabs.

The plugin works normally when e10s is disabled in the preferences.

[docwhat]

Related to #79 I think.

[docwhat]

I'm going to close this as a duplicate.

[maxigaz]

@docwhat I don't think it's related to #79. Or at least, this one is not a duplicate at all.

On the one hand, the missing edit button I described in that issue occurred with e10s disabled. (As I couldn't even enable it in FF 47.) On the other hand, in #79 the edit button was missing only while trying to edit a Stylish theme, not the small button that appears in the corner of text boxes on any web page.

By the way, I can confirm that I have the same issue as @Jereviendrai on FF 49.0.2 when e10s is on (by adding browser.tabs.remote.force-enable and setting it to true in about:config).

[HappyTetrahedron]

Sorry for disappearing for so long.

I just wanted to add that I don't use the Stylish addon, so I don't see how this is related to #79.

[docwhat]

I take it back, I don't think it is related to #79... I'm not sure what's up then.

[cjgu]

On Firefox 50.0 with e10 the button does appear if I open the inspector, but until that it is hidden.

[braham-snyder]

https://addons.mozilla.org/en-US/firefox/addon/withexeditor/ works with e10s, for those interested in switching and/or for anyone interested in patching It's All Text

for those that want to use emacsclient with WithExEditor, the combination that worked for me was to check "Put File Path After Command Line Options", leave unchecked "Run Command in A Shell", and set this .sh file as the editor:

#!/bin/bash
/usr/local/bin/emacsclient -c -a "" "$@"

[maxigaz]

@braham-snyder Thank you for the suggestion! So far it runs well with Neovim-Qt, too. I used the following in an .sh file:

#!/bin/bash
set -eu
exec /bin/nvim-qt -- "$@"

[docwhat]

withExEditor looks pretty nice, though it requires the user to setup Node.js and run a host service. It was how I was thinking of doing the next version, but using a go binary or something similar

I don't know how to fix the e10s "edit button" problem but would love any pull requests. Alternatively, someone could write a portable version of withExEditorHost and make withExEditor more simple to use for "normal" people.

[jlebon]

Just FYI, I wrote an extension with similar base functionality called Textern. It uses purely WebExtensions and should thus be fully compatible with e10s!

[docwhat]

@jlebon: Cool!

I made several attempts at doing something like that, but I kept getting lost. If you speak golang that would be ideal for this, since it could work on any platform.

I'm looking for someone to take over IAT. Would you be interested?

We could create a new branch (v2) and you could modify it to work with your python script. I could then see about translating your python script to golang with the correct platform specific libinode replacements (or falling back to polling).

Would you be willing?

[jlebon]

@docwhat Rewriting in golang sounds interesting!

Unfortunately, I don't have the bandwidth and willpower right now to invest much more time in the project beyond simple bugfixes and accepting patches. It was more of a way to exercise my JS and Python while scratching an itch. :)

I wouldn't feel comfortable making any commitment without the drive to follow through with them. Hope you understand!

[docwhat]

No worries, @jlebon. I'm in a similar boat with IAT itself. I've run out of steam on it.