Skip to content

Commit 2e04e75

Browse files
committed
📝 Update TODO
1 parent a2457e4 commit 2e04e75

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

docs/TODO.md

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,6 @@
99

1010
<br>
1111

12-
- [ ] **Refactor**: Update logic for handling images.
13-
* Copy over `RNIImageItem` impl. from `react-native-ios-navigator`.
14-
* Rename `IconConfig` type to `IconConfigDeprecated`.
15-
* Make the `icon` property accept both `IconConfigDeprecated` and `ImageItemConfig`.
16-
* Then in native, map `IconConfigDeprecated` to `ImageItemConfig`.
17-
* Then use `RNIImageItem` to create the icon images for the context menu.
18-
19-
<br>
20-
21-
- [ ] **Refactor**: Refactor to use typescript + add type annotations.
22-
- [ ] **Refactor**: Refactor example to use typescript.
23-
24-
<br>
25-
2612
- [ ] **Docs**: Update documentation sections
2713

2814
* Remove numbered subsections.
@@ -34,16 +20,8 @@
3420

3521
<br>
3622

37-
- [ ] **Sync**: Import the core libraries in `react-native-ios-context-menu`.
38-
* Import `RNIImageItem` and update `RCTMenuIcon` to use it.
39-
40-
<br>
41-
42-
- [ ]
4323
- [ ] **Implement**: Add support for targeted previews on text (i.e. similar to safari).
44-
- [ ] **Implement**: Control `ContextMenuView` via context and create `useContextMenuViewContext` hook.
4524
- [ ] **Implement**: Subscribe to `ContextMenuView` events via event emitter from context.
46-
- [ ] **Implement**: Implement `ContextMenuView` event hook (i.e. `useContextMenuViewEvents` hook).
4725

4826
<br>
4927

@@ -65,6 +43,20 @@
6543

6644
### Version: `next`
6745

46+
- [x] (Commit: `2c55fdb`) **Implement**: Implement `ContextMenuViewContext`
47+
- [x] (Commit: `05f6c73`) **Implement**: Implement `useMenuContext` hook.
48+
- [x] **Refactor**: Update example to use typescript.
49+
* Commits: `7ec95a5`, `51a50f6`, `2e3c05a`, `104d36d`, `b84a0db`, `73ff6f1`, `be6d40e`, `3bc8e2a`, `491874d`, `9596954`, `080d44f`, `497f032`, `de1f93c`, `e745dda`, `7b0c4f1`, `e714a1f`, `6483c79`, `447dd2b`, `ecd96fc`, `78a9c10`, `96877c2`, `bb3fff9`, `aea43db`, `0c5436a`, `ee446c3`, `bdee609`, `e3846d7`, `827f0bb`.
50+
51+
<br>
52+
53+
- [x] (Commit: `7045e61`) **Bugfix**: Fix types — Make `menuConfig` prop optional.
54+
- [x] (Commit: `2310b7e`) **Bugfix**: Fix types — Fix wrong type for `MenuConfig.menuAttributes`.
55+
- [x] (Commit: `52c0459`) **Bugfix**: Fix library exports — Export types from `MenuEvents`.
56+
- [x] (Commit: `9f4e332`) **Refactor**: Remove `ContextMenuButton.wrapNativeComponent` Prop.
57+
- [x] (Commit: `9caf7d7`) **Implement**: Implement `ContextMenuButtonContext`.
58+
- [x] (Commit: `4d063f9`) **Implement**: Implement `useMenuButtonContext` hook.
59+
6860
<br>
6961

7062
### Version: `1.5.0`
@@ -86,6 +78,13 @@
8678
<br>
8779

8880
- [x] **Refactor**: Update to use `RNIImageItem` for the menu icons.
81+
* Update logic for handling images.
82+
* Copy over `RNIImageItem` impl. from `react-native-ios-navigator`.
83+
* Rename `IconConfig` type to `IconConfigDeprecated`.
84+
* Make the `icon` property accept both `IconConfigDeprecated` and `ImageItemConfig`.
85+
* Then in native, map `IconConfigDeprecated` to `ImageItemConfig`.
86+
* Then use `RNIImageItem` to create the icon images for the context menu.
87+
* Import `RNIImageItem` and update `RCTMenuIcon` to use it.
8988
* (Commit: `836f0a3`) Copy over `RNIImageItem` impl. from `react-native-ios-navigator`.
9089
* (Commit: `97fa40c`) Refactor to use `RNIImageItem` for menu item icon.
9190
* (Commit: `e02d96e`) Copy over `ImageItemConfig` types from `react-native-ios-navigator`.

0 commit comments

Comments
 (0)