-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Description
I noticed this while working on #117410:
runtime/src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Read.cs
Lines 372 to 377 in 513ff1a
| int checksum = (int)TarHelpers.ParseOctal<uint>(spanChecksum); | |
| // Zero checksum means the whole header is empty | |
| if (checksum == 0) | |
| { | |
| return null; | |
| } |
There's no reason to treat zero separate from any other checksum value.
I think this code should be removed.
@ericstj @dotnet/area-system-formats-tar wdyt?