Skip to content

Commit 5679b57

Browse files
authored
Remove dry-configurable setting overload (#201)
This is no longer needed after the changes in dry-configurable 0.14.0.
1 parent 6a3407a commit 5679b57

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

lib/dry/system/container.rb

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -100,18 +100,6 @@ def strategies(value = nil)
100100

101101
extend Dry::Core::Deprecations["Dry::System::Container"]
102102

103-
# Define a new configuration setting
104-
#
105-
# @see https://dry-rb.org/gems/dry-configurable
106-
#
107-
# @api public
108-
def setting(name, default = Dry::Core::Constants::Undefined, **options, &block)
109-
super(name, default, **options, &block)
110-
# TODO: dry-configurable needs a public API for this
111-
config._settings << _settings[name]
112-
self
113-
end
114-
115103
# Configures the container
116104
#
117105
# @example

project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ gemspec:
1111
runtime_dependencies:
1212
- [concurrent-ruby, "~> 1.0"]
1313
- [dry-auto_inject, ">= 0.4.0"]
14-
- [dry-configurable, "~> 0.13", ">= 0.13.0"]
14+
- [dry-configurable, "~> 0.14", ">= 0.14.0"]
1515
- [dry-container, "~> 0.9", ">= 0.9.0"]
1616
- [dry-core, "~> 0.5", ">= 0.5"]
1717
- [dry-inflector, "~> 0.1", ">= 0.1.2"]

0 commit comments

Comments
 (0)