Fix no message for zero trackers

Bug: Tracker Status UI: No Message for Zero Trackers.

The TrackerStatus function computes totalTrackersPillText for the
zero-trackers case but never displays it. When totalTrackersBlocked ===
0, the condition {totalTrackersBlocked > 0 && <TickPill .../>} prevents
rendering any tracker status message. The legacy TrackerStatusLegacy
displays "No trackers blocked" or "No trackers found" in this scenario,
but the new implementation shows nothing, breaking the expected UI
behavior for sites with no blocked trackers.

#2039 (comment)

Author: jsoningram

special-pages/pages/new-tab/app/activity/components/Activity.js

@@ -253,7 +253,7 @@ function TrackerStatus({ id, trackersFound }) {
     return (
         <div class={styles.companiesIconRow} data-testid="TrackerStatus">
             <div class={styles.companiesText}>
-                {totalTrackersBlocked > 0 && <TickPill text={totalTrackersPillText} />}
+                <TickPill text={totalTrackersPillText} />
                 {cookiePopUpBlocked && <TickPill text={t('activity_cookiePopUpBlocked')} />}
             </div>
         </div>

special-pages/pages/new-tab/app/activity/integration-tests/activity.page.js

@@ -395,6 +395,41 @@ export class ActivityPage {
           `);
     }
 
+    /**
+     * Test that the new TrackerStatus component displays zero-tracker messages when CPM is enabled
+     */
+    async showsZeroTrackerMessagesWithCpm() {
+        // Twitter has trackersFound: true, totalCount: 0 → should show "No trackers blocked"
+        await expect(this.context().getByTestId('ActivityItem').nth(3)).toMatchAriaSnapshot(`
+          - listitem:
+            - link "twitter.com"
+            - button "Add twitter.com to favorites":
+              - img
+            - button "Clear browsing history and data for twitter.com":
+              - img
+            - text: No trackers blocked
+            - list:
+              - listitem:
+                - link "Trending Topics"
+                - text: 2 days ago
+        `);
+
+        // LinkedIn has trackersFound: false, totalCount: 0 → should show "No trackers found"
+        await expect(this.context().getByTestId('ActivityItem').nth(4)).toMatchAriaSnapshot(`
+          - listitem:
+            - link "app.linkedin.com"
+            - button "Add app.linkedin.com to favorites":
+              - img
+            - button "Clear browsing history and data for app.linkedin.com":
+              - img
+            - text: No trackers found
+            - list:
+              - listitem:
+                - link "Profile Page"
+                - text: 2 hrs ago
+        `);
+    }
+
     async hasEmptyTrackersOnlyTitle() {
         const { page } = this;
         await expect(page.getByTestId('ActivityHeading')).toMatchAriaSnapshot(`

special-pages/pages/new-tab/app/activity/integration-tests/activity.spec.js

@@ -116,6 +116,14 @@ test.describe('activity widget', () => {
         await ap.didRender();
         await ap.hidesCookiePopupIndicatorWhenNotBlocked();
     });
+    test('shows zero-tracker messages with new component when CPM enabled', async ({ page }, workerInfo) => {
+        const ntp = NewtabPage.create(page, workerInfo);
+        const ap = new ActivityPage(page, ntp);
+        await ntp.reducedMotion();
+        await ntp.openPage({ additional: { ...defaultPageParams, cpm: 'true' } });
+        await ap.didRender();
+        await ap.showsZeroTrackerMessagesWithCpm();
+    });
     test('after rendering and navigating to a new tab, data is re-requested on return', async ({ page }, workerInfo) => {
         const ntp = NewtabPage.create(page, workerInfo);
         const ap = new ActivityPage(page, ntp);