Merge pull request #15 from dynamicweb/sha/25224-quickpay-callback-fix

QuickPay callback fix

Author: dw-sha

.github/CODEOWNERS

@@ -1 +1 @@
-*	@frederik5480
+*	@dynamicweb/commerce-codeowners

src/Dynamicweb.Ecommerce.CheckoutHandlers.QuickPayPaymentWindow.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<VersionPrefix>10.1.1</VersionPrefix>
+		<VersionPrefix>10.1.2</VersionPrefix>
 		<AssemblyVersion>1.0.0.0</AssemblyVersion>
 		<Title>QuickPay Payment Window</Title>
 		<Description>The QuickPay Payment Window checkout handler is designed to work with QuickPay v10.</Description>

src/QuickPayPaymentWindow.cs

@@ -321,7 +321,7 @@ public override OutputResult BeginCheckout(Order order, CheckoutParameters param
         catch (Exception ex)
         {
             LogError(order, ex, "Unhandled exception with message: {0}", ex.Message);
-            return PrintErrorTemplate(order, ex.Message);
+            return new ContentOutputResult() { Content = "An error occurred in the callback. Check event log for error details" };
         }
 
         QuickpayTemplateHelper GetTemplateHelper() => new()
@@ -378,7 +378,7 @@ public override OutputResult HandleRequest(Order order)
         catch (Exception ex)
         {
             LogError(order, ex, "Unhandled exception with message: {0}", ex.Message);
-            return PrintErrorTemplate(order, ex.Message);
+            return new ContentOutputResult() { Content = "An error occurred in the callback. Check event log for error details" };
         }
     }
 
@@ -566,15 +566,21 @@ private void Callback(Order order)
     {
         lock (lockObject)
         {
+            if (Context.Current.Request.InputStream.Length == 0)
+            {
+                LogEvent(order, "Invalid callback - no InputStream or not a POST");
+                return;
+            }
+
             LogEvent(order, "Callback started");
-            string callbackResponce;
+            string callbackResponse;
 
             using (StreamReader reader = new StreamReader(Context.Current.Request.InputStream, Encoding.UTF8))
             {
-                callbackResponce = reader.ReadToEndAsync().GetAwaiter().GetResult();
+                callbackResponse = reader.ReadToEndAsync().GetAwaiter().GetResult();
             }
 
-            CheckedData checkedData = CheckData(order, callbackResponce ?? string.Empty, order.Price.PricePIP);
+            CheckedData checkedData = CheckData(order, callbackResponse ?? string.Empty, order.Price.PricePIP);
             string resultInfo = checkedData.Result switch
             {
                 //ViaBill autocapture starts callback.