Merge pull request #55 from dynamicweb/dbe/25199-Fix-Index-out-of-range

Fix "Index was out of range" due to discount line

Author: DWDBE

src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Dynamicweb.Ecommerce.DynamicwebLiveIntegration.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 	<PropertyGroup>
-		<Version>10.4.28</Version>		
+		<Version>10.4.29</Version>		
 		<AssemblyVersion>1.0.0.0</AssemblyVersion>
 		<Title>Live Integration</Title>
 		<Description>Live Integration</Description>

src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/OrderHandler.cs

@@ -638,6 +638,7 @@ private static void ProcessOrderLines(Settings settings, XmlDocument response, O
 
                 bool keepDiscountOrderLines = !settings.ErpControlsDiscount && order.Complete;
                 // Remove deleted OrderLines
+                List<OrderLine> linesToRemove = new List<OrderLine>();
                 for (int i = order.OrderLines.Count - 1; i >= 0; i--)
                 {
                     var orderLine = order.OrderLines[i];
@@ -650,6 +651,10 @@ private static void ProcessOrderLines(Settings settings, XmlDocument response, O
                     {
                         continue;
                     }
+                    linesToRemove.Add(orderLine);                    
+                }
+                foreach (var orderLine in linesToRemove)
+                {
                     order.OrderLines.Remove(orderLine);
                     Services.OrderLines.Delete(orderLine.Id);
                 }