-
Notifications
You must be signed in to change notification settings - Fork 71
fix: ptl 2.6.0 explicitly pass weights_only=False #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cathalobrien
merged 2 commits into
main
from
fix/ptl-checkpoints-explicit-weights-only-false
Nov 28, 2025
Merged
fix: ptl 2.6.0 explicitly pass weights_only=False #710
cathalobrien
merged 2 commits into
main
from
fix/ptl-checkpoints-explicit-weights-only-false
Nov 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anaprietonem
approved these changes
Nov 28, 2025
Contributor
anaprietonem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
flyIchtus
pushed a commit
that referenced
this pull request
Dec 1, 2025
## Description [this](Lightning-AI/pytorch-lightning#21072) change in ptl 2.6.0 means we have to explicitly specify "weight_only=False" when calling `BaseGraphModule.load_from_checkpoint` (nice spot Ana!) ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
JPXKQX
pushed a commit
that referenced
this pull request
Dec 5, 2025
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- <details><summary>training: 0.8.0</summary> ## [0.8.0](training-0.7.0...training-0.8.0) (2025-12-05) ### ⚠ BREAKING CHANGES * **training:** Refactor configuration by introducing system schema with hardware, paths, and files subschemas ([#598](#598)) * cond layer norm ([#658](#658)) ### Features * Activate minmium plotting for integration tests ([#669](#669)) ([84e5882](84e5882)) * Compile transformer gnn ([#181](#181)) ([24d162c](24d162c)) * **models:** Add configurable residual connections in enc-proc-dec ([#670](#670)) ([aeaf00b](aeaf00b)) * **models:** Triton GraphTransformer ([#631](#631)) ([b40b6c6](b40b6c6)) * Time_interpolator_callbacks ([#677](#677)) ([c2b8179](c2b8179)) * **training:** Performance docs ([#696](#696)) ([9574ff1](9574ff1)) * **training:** Refactor optimizer creation to support custom and torch optimizers ([#588](#588)) ([cd777fb](cd777fb)) ### Bug Fixes * Add package config path to Hydra search path in plugin ([#656](#656)) ([ca6f732](ca6f732)) * Cond layer norm ([#658](#658)) ([7315e3a](7315e3a)) * **logger:** Bugs in AzureMLFlowLogger from [#646](#646) ([#685](#685)) ([14c0235](14c0235)) * **models:** Processor chunking ([#629](#629)) ([06e5533](06e5533)) * Pass weights_only for pytorch lightning >= 2.6.0 ([#713](#713)) ([7446942](7446942)) * Ptl 2.6.0 explicitly pass weights_only=False ([#710](#710)) ([e18824c](e18824c)) * RolloutEval sharding ([#714](#714)) ([0fbc071](0fbc071)) * Slurm system config ([#702](#702)) ([cce8763](cce8763)) * Target docs ([#704](#704)) ([200101e](200101e)) * **training,tasks:** Abstract RolloutForecasting task ([#682](#682)) ([f14fc32](f14fc32)) * **training:** CombinedLoss schema validation ([#719](#719)) ([dba4268](dba4268)) * **training:** Refactor configuration by introducing system schema with hardware, paths, and files subschemas ([#598](#598)) ([da02fe7](da02fe7)) * **training:** Remove unused code ([#706](#706)) ([f49813a](f49813a)) </details> <details><summary>graphs: 0.8.0</summary> ## [0.8.0](graphs-0.7.2...graphs-0.8.0) (2025-12-05) ### ⚠ BREAKING CHANGES * **edges:** Edge feature revision #643 ([#727](#727)) ### Features * **edges:** Edge feature revision ([#643](#643)) ([720f4d8](720f4d8)) * **edges:** Edge feature revision [#643](#643) ([#727](#727)) ([d1372cf](d1372cf)) * **graphs:** Support for multi-scale connections with HEALPix hidden grid ([#691](#691)) ([1450787](1450787)) ### Bug Fixes * Revert "feat(edges): Edge feature revision" ([#726](#726)) ([db1f940](db1f940)) * Sparse export ([#686](#686)) ([969b787](969b787)) * Target docs ([#704](#704)) ([200101e](200101e)) </details> <details><summary>models: 0.11.0</summary> ## [0.11.0](models-0.10.0...models-0.11.0) (2025-12-05) ### ⚠ BREAKING CHANGES * **training:** Refactor configuration by introducing system schema with hardware, paths, and files subschemas ([#598](#598)) * cond layer norm ([#658](#658)) ### Features * Compile transformer gnn ([#181](#181)) ([24d162c](24d162c)) * **models:** Add configurable residual connections in enc-proc-dec ([#670](#670)) ([aeaf00b](aeaf00b)) * **models:** Multibackend all_to_all wrapper ([#95](#95)) ([6819be1](6819be1)) * **models:** Triton GraphTransformer ([#631](#631)) ([b40b6c6](b40b6c6)) ### Bug Fixes * Compile pickle error ([#708](#708)) ([f4fc4ab](f4fc4ab)) * Cond layer norm ([#658](#658)) ([7315e3a](7315e3a)) * **models:** Processor chunking ([#629](#629)) ([06e5533](06e5533)) * Predict_step shard shapes ([#692](#692)) ([be9ff8b](be9ff8b)) * Remove import of anemoi training in compile ([#705](#705)) ([f7d5ae4](f7d5ae4)) * Small pytorch boxcox inefficiency ([#683](#683)) ([66b40e0](66b40e0)) * **training:** Refactor configuration by introducing system schema with hardware, paths, and files subschemas ([#598](#598)) ([da02fe7](da02fe7)) </details> --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. > >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
mpvginde
pushed a commit
that referenced
this pull request
Dec 8, 2025
## Description [this](Lightning-AI/pytorch-lightning#21072) change in ptl 2.6.0 means we have to explicitly specify "weight_only=False" when calling `BaseGraphModule.load_from_checkpoint` (nice spot Ana!) ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this change in ptl 2.6.0 means we have to explicitly specify "weight_only=False" when calling
BaseGraphModule.load_from_checkpoint(nice spot Ana!)As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.