Skip to content

Conversation

@cathalobrien
Copy link
Contributor

Description

this change in ptl 2.6.0 means we have to explicitly specify "weight_only=False" when calling BaseGraphModule.load_from_checkpoint (nice spot Ana!)

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Nov 28, 2025
@cathalobrien cathalobrien changed the title fic: ptl 2.6.0 explicitly pass weights_only=False Fix: ptl 2.6.0 explicitly pass weights_only=False Nov 28, 2025
@cathalobrien cathalobrien added the ATS Approval Not Needed No approval needed by ATS label Nov 28, 2025
@cathalobrien cathalobrien changed the title Fix: ptl 2.6.0 explicitly pass weights_only=False fix: ptl 2.6.0 explicitly pass weights_only=False Nov 28, 2025
Copy link
Contributor

@anaprietonem anaprietonem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from To be triaged to For merging in Anemoi-dev Nov 28, 2025
@cathalobrien cathalobrien merged commit e18824c into main Nov 28, 2025
16 of 20 checks passed
@cathalobrien cathalobrien deleted the fix/ptl-checkpoints-explicit-weights-only-false branch November 28, 2025 17:35
@github-project-automation github-project-automation bot moved this from For merging to Done in Anemoi-dev Nov 28, 2025
@DeployDuck DeployDuck mentioned this pull request Nov 27, 2025
flyIchtus pushed a commit that referenced this pull request Dec 1, 2025
## Description
[this](Lightning-AI/pytorch-lightning#21072)
change in ptl 2.6.0 means we have to explicitly specify
"weight_only=False" when calling `BaseGraphModule.load_from_checkpoint`
(nice spot Ana!)

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

By opening this pull request, I affirm that all authors agree to the
[Contributor License
Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
JPXKQX pushed a commit that referenced this pull request Dec 5, 2025
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


<details><summary>training: 0.8.0</summary>

##
[0.8.0](training-0.7.0...training-0.8.0)
(2025-12-05)


### ⚠ BREAKING CHANGES

* **training:** Refactor configuration by introducing system schema with
hardware, paths, and files subschemas
([#598](#598))
* cond layer norm
([#658](#658))

### Features

* Activate minmium plotting for integration tests
([#669](#669))
([84e5882](84e5882))
* Compile transformer gnn
([#181](#181))
([24d162c](24d162c))
* **models:** Add configurable residual connections in enc-proc-dec
([#670](#670))
([aeaf00b](aeaf00b))
* **models:** Triton GraphTransformer
([#631](#631))
([b40b6c6](b40b6c6))
* Time_interpolator_callbacks
([#677](#677))
([c2b8179](c2b8179))
* **training:** Performance docs
([#696](#696))
([9574ff1](9574ff1))
* **training:** Refactor optimizer creation to support custom and torch
optimizers ([#588](#588))
([cd777fb](cd777fb))


### Bug Fixes

* Add package config path to Hydra search path in plugin
([#656](#656))
([ca6f732](ca6f732))
* Cond layer norm
([#658](#658))
([7315e3a](7315e3a))
* **logger:** Bugs in AzureMLFlowLogger from
[#646](#646)
([#685](#685))
([14c0235](14c0235))
* **models:** Processor chunking
([#629](#629))
([06e5533](06e5533))
* Pass weights_only for pytorch lightning &gt;= 2.6.0
([#713](#713))
([7446942](7446942))
* Ptl 2.6.0 explicitly pass weights_only=False
([#710](#710))
([e18824c](e18824c))
* RolloutEval sharding
([#714](#714))
([0fbc071](0fbc071))
* Slurm system config
([#702](#702))
([cce8763](cce8763))
* Target docs ([#704](#704))
([200101e](200101e))
* **training,tasks:** Abstract RolloutForecasting task
([#682](#682))
([f14fc32](f14fc32))
* **training:** CombinedLoss schema validation
([#719](#719))
([dba4268](dba4268))
* **training:** Refactor configuration by introducing system schema with
hardware, paths, and files subschemas
([#598](#598))
([da02fe7](da02fe7))
* **training:** Remove unused code
([#706](#706))
([f49813a](f49813a))
</details>

<details><summary>graphs: 0.8.0</summary>

##
[0.8.0](graphs-0.7.2...graphs-0.8.0)
(2025-12-05)


### ⚠ BREAKING CHANGES

* **edges:** Edge feature revision #643
([#727](#727))

### Features

* **edges:** Edge feature revision
([#643](#643))
([720f4d8](720f4d8))
* **edges:** Edge feature revision
[#643](#643)
([#727](#727))
([d1372cf](d1372cf))
* **graphs:** Support for multi-scale connections with HEALPix hidden
grid ([#691](#691))
([1450787](1450787))


### Bug Fixes

* Revert "feat(edges): Edge feature revision"
([#726](#726))
([db1f940](db1f940))
* Sparse export
([#686](#686))
([969b787](969b787))
* Target docs ([#704](#704))
([200101e](200101e))
</details>

<details><summary>models: 0.11.0</summary>

##
[0.11.0](models-0.10.0...models-0.11.0)
(2025-12-05)


### ⚠ BREAKING CHANGES

* **training:** Refactor configuration by introducing system schema with
hardware, paths, and files subschemas
([#598](#598))
* cond layer norm
([#658](#658))

### Features

* Compile transformer gnn
([#181](#181))
([24d162c](24d162c))
* **models:** Add configurable residual connections in enc-proc-dec
([#670](#670))
([aeaf00b](aeaf00b))
* **models:** Multibackend all_to_all wrapper
([#95](#95))
([6819be1](6819be1))
* **models:** Triton GraphTransformer
([#631](#631))
([b40b6c6](b40b6c6))


### Bug Fixes

* Compile pickle error
([#708](#708))
([f4fc4ab](f4fc4ab))
* Cond layer norm
([#658](#658))
([7315e3a](7315e3a))
* **models:** Processor chunking
([#629](#629))
([06e5533](06e5533))
* Predict_step shard shapes
([#692](#692))
([be9ff8b](be9ff8b))
* Remove import of anemoi training in compile
([#705](#705))
([f7d5ae4](f7d5ae4))
* Small pytorch boxcox inefficiency
([#683](#683))
([66b40e0](66b40e0))
* **training:** Refactor configuration by introducing system schema with
hardware, paths, and files subschemas
([#598](#598))
([da02fe7](da02fe7))
</details>

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> 
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
mpvginde pushed a commit that referenced this pull request Dec 8, 2025
## Description
[this](Lightning-AI/pytorch-lightning#21072)
change in ptl 2.6.0 means we have to explicitly specify
"weight_only=False" when calling `BaseGraphModule.load_from_checkpoint`
(nice spot Ana!)

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

By opening this pull request, I affirm that all authors agree to the
[Contributor License
Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS Approval Not Needed No approval needed by ATS training

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants