[goals] [wip] Show info waiting #216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
added a commit
that referenced
this pull request
Jan 23, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 23, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 23, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 24, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 25, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 27, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 27, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 27, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
added a commit
that referenced
this pull request
Jan 27, 2023
This is prerequisite to implement / fix effectively #143 and #216 for example; the current Info View rendering using strings doesn't scale anymore to the kind of DOM manipulation we need. Why React? That was a careful choice for many reasons, in particular seems like the best fit for our use case (so far); moreover, 3rd party package support is the best.
ejgallego
force-pushed
the
goals_show_info_waiting
branch
from
a7c1a3c to
913ccb2
Compare
We need to do a setTimeout here to avoid flicker.
ejgallego
force-pushed
the
goals_show_info_waiting
branch
from
913ccb2 to
69c925e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to do a setTimeout here to avoid flicker.