Skip to content

Commit a556fb4

Browse files
dependabot[bot]github-actions[bot]kruskall
authored
build(deps): bump github.com/elastic/apm-aggregation from 1.4.0 to 1.5.0 (#18611)
* build(deps): bump github.com/elastic/apm-aggregation from 1.4.0 to 1.5.0 Bumps [github.com/elastic/apm-aggregation](https://github.com/elastic/apm-aggregation) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/elastic/apm-aggregation/releases) - [Commits](elastic/apm-aggregation@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/elastic/apm-aggregation dependency-version: 1.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update NOTICE.txt * Update NOTICE-fips.txt * lint: fix compile errors * fix: use CompactionConcurrencyRange to replace MaxConcurrentCompactions MaxConcurrentCompactions was renamed and updated to return a range --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: kruskal <[email protected]>
1 parent 9b3ed3b commit a556fb4

File tree

6 files changed

+988
-187
lines changed

6 files changed

+988
-187
lines changed

NOTICE-fips.txt

Lines changed: 477 additions & 80 deletions
Large diffs are not rendered by default.

NOTICE.txt

Lines changed: 477 additions & 80 deletions
Large diffs are not rendered by default.

go.mod

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ go 1.25.3
55
require (
66
github.com/KimMachineGun/automemlimit v0.7.4
77
github.com/cespare/xxhash/v2 v2.3.0
8-
github.com/cockroachdb/pebble/v2 v2.0.7
8+
github.com/cockroachdb/pebble/v2 v2.1.0
99
github.com/dustin/go-humanize v1.0.1
10-
github.com/elastic/apm-aggregation v1.4.0
10+
github.com/elastic/apm-aggregation v1.5.0
1111
github.com/elastic/apm-data v1.19.5
1212
github.com/elastic/beats/v7 v7.0.0-alpha2.0.20251022124708-19bdf8ce42d3
1313
github.com/elastic/elastic-agent-client/v7 v7.17.2
@@ -55,12 +55,14 @@ require (
5555
dario.cat/mergo v1.0.1 // indirect
5656
github.com/AlekSi/pointer v1.2.0 // indirect
5757
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c // indirect
58-
github.com/DataDog/zstd v1.5.6 // indirect
58+
github.com/DataDog/zstd v1.5.7 // indirect
5959
github.com/Masterminds/goutils v1.1.1 // indirect
6060
github.com/Masterminds/semver/v3 v3.3.1 // indirect
6161
github.com/Masterminds/sprig/v3 v3.3.0 // indirect
6262
github.com/Microsoft/go-winio v0.6.2 // indirect
6363
github.com/ProtonMail/go-crypto v1.1.4 // indirect
64+
github.com/RaduBerinde/axisds v0.0.0-20250419182453-5135a0650657 // indirect
65+
github.com/RaduBerinde/btreemap v0.0.0-20250419174037-3d62b7205d54 // indirect
6466
github.com/agext/levenshtein v1.2.3 // indirect
6567
github.com/akavel/rsrc v0.10.2 // indirect
6668
github.com/apparentlymart/go-textseg/v15 v15.0.0 // indirect
@@ -76,9 +78,8 @@ require (
7678
github.com/caarlos0/go-version v0.2.0 // indirect
7779
github.com/cavaliergopher/cpio v1.0.1 // indirect
7880
github.com/cloudflare/circl v1.6.1 // indirect
79-
github.com/cockroachdb/crlib v0.0.0-20241015224233-894974b3ad94 // indirect
81+
github.com/cockroachdb/crlib v0.0.0-20241112164430-1264a2edc35b // indirect
8082
github.com/cockroachdb/errors v1.11.3 // indirect
81-
github.com/cockroachdb/fifo v0.0.0-20240816210425-c5d0cb0b6fc0 // indirect
8283
github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b // indirect
8384
github.com/cockroachdb/redact v1.1.5 // indirect
8485
github.com/cockroachdb/swiss v0.0.0-20250624142022-d6e517c1d961 // indirect
@@ -163,6 +164,7 @@ require (
163164
github.com/mattn/go-colorable v0.1.13 // indirect
164165
github.com/mattn/go-isatty v0.0.20 // indirect
165166
github.com/mileusna/useragent v1.3.5 // indirect
167+
github.com/minio/minlz v1.0.1-0.20250507153514-87eb42fe8882 // indirect
166168
github.com/mitchellh/copystructure v1.2.0 // indirect
167169
github.com/mitchellh/go-homedir v1.1.0 // indirect
168170
github.com/mitchellh/go-testing-interface v1.14.1 // indirect

go.sum

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ github.com/AzureAD/microsoft-authentication-library-for-go v1.4.2 h1:oygO0locgZJ
1515
github.com/AzureAD/microsoft-authentication-library-for-go v1.4.2/go.mod h1:wP83P5OoQ5p6ip3ScPr0BAq0BvuPAvacpEuSzyouqAI=
1616
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c h1:pxW6RcqyfI9/kWtOwnv/G+AzdKuy2ZrqINhenH4HyNs=
1717
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho=
18-
github.com/DataDog/zstd v1.5.6 h1:LbEglqepa/ipmmQJUDnSsfvA8e8IStVcGaFWDuxvGOY=
19-
github.com/DataDog/zstd v1.5.6/go.mod h1:g4AWEaM3yOg3HYfnJ3YIawPnVdXJh9QME85blwSAmyw=
18+
github.com/DataDog/zstd v1.5.7 h1:ybO8RBeh29qrxIhCA9E8gKY6xfONU9T6G6aP9DTKfLE=
19+
github.com/DataDog/zstd v1.5.7/go.mod h1:g4AWEaM3yOg3HYfnJ3YIawPnVdXJh9QME85blwSAmyw=
2020
github.com/HdrHistogram/hdrhistogram-go v1.1.2 h1:5IcZpTvzydCQeHzK4Ef/D5rrSqwxob0t8PQPMybUNFM=
2121
github.com/HdrHistogram/hdrhistogram-go v1.1.2/go.mod h1:yDgFjdqOqDEKOvasDdhWNXYg9BVp4O+o5f6V/ehm6Oo=
2222
github.com/KimMachineGun/automemlimit v0.7.4 h1:UY7QYOIfrr3wjjOAqahFmC3IaQCLWvur9nmfIn6LnWk=
@@ -36,6 +36,10 @@ github.com/ProtonMail/go-mime v0.0.0-20230322103455-7d82a3887f2f h1:tCbYj7/299ek
3636
github.com/ProtonMail/go-mime v0.0.0-20230322103455-7d82a3887f2f/go.mod h1:gcr0kNtGBqin9zDW9GOHcVntrwnjrK+qdJ06mWYBybw=
3737
github.com/ProtonMail/gopenpgp/v2 v2.7.1 h1:Awsg7MPc2gD3I7IFac2qE3Gdls0lZW8SzrFZ3k1oz0s=
3838
github.com/ProtonMail/gopenpgp/v2 v2.7.1/go.mod h1:/BU5gfAVwqyd8EfC3Eu7zmuhwYQpKs+cGD8M//iiaxs=
39+
github.com/RaduBerinde/axisds v0.0.0-20250419182453-5135a0650657 h1:8XBWWQD+vFF+JqOsm16t0Kab1a7YWV8+GISVEP8AuZ8=
40+
github.com/RaduBerinde/axisds v0.0.0-20250419182453-5135a0650657/go.mod h1:UHGJonU9z4YYGKJxSaC6/TNcLOBptpmM5m2Cksbnw0Y=
41+
github.com/RaduBerinde/btreemap v0.0.0-20250419174037-3d62b7205d54 h1:bsU8Tzxr/PNz75ayvCnxKZWEYdLMPDkUgticP4a4Bvk=
42+
github.com/RaduBerinde/btreemap v0.0.0-20250419174037-3d62b7205d54/go.mod h1:0tr7FllbE9gJkHq7CVeeDDFAFKQVy5RnCSSNBOvdqbc=
3943
github.com/aclements/go-perfevent v0.0.0-20240301234650-f7843625020f h1:JjxwchlOepwsUWcQwD2mLUAGE9aCp0/ehy6yCHFBOvo=
4044
github.com/aclements/go-perfevent v0.0.0-20240301234650-f7843625020f/go.mod h1:tMDTce/yLLN/SK8gMOxQfnyeMeCg8KGzp0D1cbECEeo=
4145
github.com/agext/levenshtein v1.2.1/go.mod h1:JEDfjyjHDjOF/1e4FlBE/PkbqA9OfWu2ki2W0IB5558=
@@ -110,20 +114,18 @@ github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UF
110114
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
111115
github.com/cloudflare/circl v1.6.1 h1:zqIqSPIndyBh1bjLVVDHMPpVKqp8Su/V+6MeDzzQBQ0=
112116
github.com/cloudflare/circl v1.6.1/go.mod h1:uddAzsPgqdMAYatqJ0lsjX1oECcQLIlRpzZh3pJrofs=
113-
github.com/cockroachdb/crlib v0.0.0-20241015224233-894974b3ad94 h1:bvJv505UUfjzbaIPdNS4AEkHreDqQk6yuNpsdRHpwFA=
114-
github.com/cockroachdb/crlib v0.0.0-20241015224233-894974b3ad94/go.mod h1:Gq51ZeKaFCXk6QwuGM0w1dnaOqc/F5zKT2zA9D6Xeac=
115-
github.com/cockroachdb/datadriven v1.0.3-0.20240530155848-7682d40af056 h1:slXychO2uDM6hYRu4c0pD0udNI8uObfeKN6UInWViS8=
116-
github.com/cockroachdb/datadriven v1.0.3-0.20240530155848-7682d40af056/go.mod h1:a9RdTaap04u637JoCzcUoIcDmvwSUtcUFtT/C3kJlTU=
117+
github.com/cockroachdb/crlib v0.0.0-20241112164430-1264a2edc35b h1:SHlYZ/bMx7frnmeqCu+xm0TCxXLzX3jQIVuFbnFGtFU=
118+
github.com/cockroachdb/crlib v0.0.0-20241112164430-1264a2edc35b/go.mod h1:Gq51ZeKaFCXk6QwuGM0w1dnaOqc/F5zKT2zA9D6Xeac=
119+
github.com/cockroachdb/datadriven v1.0.3-0.20250407164829-2945557346d5 h1:UycK/E0TkisVrQbSoxvU827FwgBBcZ95nRRmpj/12QI=
120+
github.com/cockroachdb/datadriven v1.0.3-0.20250407164829-2945557346d5/go.mod h1:jsaKMvD3RBCATk1/jbUZM8C9idWBJME9+VRZ5+Liq1g=
117121
github.com/cockroachdb/errors v1.11.3 h1:5bA+k2Y6r+oz/6Z/RFlNeVCesGARKuC6YymtcDrbC/I=
118122
github.com/cockroachdb/errors v1.11.3/go.mod h1:m4UIW4CDjx+R5cybPsNrRbreomiFqt8o1h1wUVazSd8=
119-
github.com/cockroachdb/fifo v0.0.0-20240816210425-c5d0cb0b6fc0 h1:pU88SPhIFid6/k0egdR5V6eALQYq2qbSmukrkgIh/0A=
120-
github.com/cockroachdb/fifo v0.0.0-20240816210425-c5d0cb0b6fc0/go.mod h1:9/y3cnZ5GKakj/H4y9r9GTjCvAFta7KLgSHPJJYc52M=
121123
github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b h1:r6VH0faHjZeQy818SGhaone5OnYfxFR/+AzdY3sf5aE=
122124
github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b/go.mod h1:Vz9DsVWQQhf3vs21MhPMZpMGSht7O/2vFW2xusFUVOs=
123125
github.com/cockroachdb/metamorphic v0.0.0-20231108215700-4ba948b56895 h1:XANOgPYtvELQ/h4IrmPAohXqe2pWA8Bwhejr3VQoZsA=
124126
github.com/cockroachdb/metamorphic v0.0.0-20231108215700-4ba948b56895/go.mod h1:aPd7gM9ov9M8v32Yy5NJrDyOcD8z642dqs+F0CeNXfA=
125-
github.com/cockroachdb/pebble/v2 v2.0.7 h1:9TkE155mj6KPO14+06z8Jytbm7JVs0Einn+pKWNyPWQ=
126-
github.com/cockroachdb/pebble/v2 v2.0.7/go.mod h1:un1DXG73PKw3F7Ndd30YactyvsFviI9Fuhe0tENdnyA=
127+
github.com/cockroachdb/pebble/v2 v2.1.0 h1:6KZvjSpWcEXZUvlLzTRC7T1A2G7r+bFskIzggklxixo=
128+
github.com/cockroachdb/pebble/v2 v2.1.0/go.mod h1:Aza05DCCc05ghIJZkB4Q/axv/JK9wx5cFwWcnhG0eGw=
127129
github.com/cockroachdb/redact v1.1.5 h1:u1PMllDkdFfPWaNGMyLD1+so+aq3uUItthCFqzwPJ30=
128130
github.com/cockroachdb/redact v1.1.5/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=
129131
github.com/cockroachdb/swiss v0.0.0-20250624142022-d6e517c1d961 h1:Nua446ru3juLHLZd4AwKNzClZgL1co3pUPGv3o8FlcA=
@@ -165,8 +167,8 @@ github.com/eapache/queue v1.1.0 h1:YOEu7KNc61ntiQlcEeUIoDTJ2o8mQznoNvUhiigpIqc=
165167
github.com/eapache/queue v1.1.0/go.mod h1:6eCeP0CKFpHLu8blIFXhExK/dRa7WDZfr6jVFPTqq+I=
166168
github.com/ebitengine/purego v0.9.0-alpha.3.0.20250507171635-5047c08daa38 h1:61WY14WhyU89bEJCjegpt6b8wDNsU+Z1416JGwfEKwI=
167169
github.com/ebitengine/purego v0.9.0-alpha.3.0.20250507171635-5047c08daa38/go.mod h1:iIjxzd6CiRiOG0UyXP+V1+jWqUXVjPKLAI0mRfJZTmQ=
168-
github.com/elastic/apm-aggregation v1.4.0 h1:gBZr7NLnHItpTELuGfJ/Gz/NAPyBhgqrI3c2EglCv7g=
169-
github.com/elastic/apm-aggregation v1.4.0/go.mod h1:E3osgdOGlm2tV/rcA6MZFmKhYtSXZWcH/Xt7xkVqBzA=
170+
github.com/elastic/apm-aggregation v1.5.0 h1:56AFqsRN7aQ+QakXGWxa39rI/MMvbgoWWS452am+AR0=
171+
github.com/elastic/apm-aggregation v1.5.0/go.mod h1:6iDxT2Ts9Pr+Ulb5z5FMUIp5nEqZTgBKnGNjKHEBFzU=
170172
github.com/elastic/apm-data v1.19.5 h1:Rc8bcArUpDMv4wluw6G+LdBlGEO16nO+gnNuKUArbmc=
171173
github.com/elastic/apm-data v1.19.5/go.mod h1:jfJZw+SiGv0y5jIeAjmzIxixRIfLuWREOYgNvmhcek8=
172174
github.com/elastic/apm-perf v0.0.0-20250207152505-1dbeb202ff22 h1:br+XeQOcxNFSv+HzO3jC0bjIBgG6FJeBn7oXQFQvKtM=
@@ -431,6 +433,8 @@ github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWE
431433
github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
432434
github.com/mileusna/useragent v1.3.5 h1:SJM5NzBmh/hO+4LGeATKpaEX9+b4vcGg2qXGLiNGDws=
433435
github.com/mileusna/useragent v1.3.5/go.mod h1:3d8TOmwL/5I8pJjyVDteHtgDGcefrFUX4ccGOMKNYYc=
436+
github.com/minio/minlz v1.0.1-0.20250507153514-87eb42fe8882 h1:0lgqHvJWHLGW5TuObJrfyEi6+ASTKDBWikGvPqy9Yiw=
437+
github.com/minio/minlz v1.0.1-0.20250507153514-87eb42fe8882/go.mod h1:qT0aEB35q79LLornSzeDH75LBf3aH1MV+jB5w9Wasec=
434438
github.com/mitchellh/copystructure v1.2.0 h1:vpKXTN4ewci03Vljg/q9QvCGUDttBOGBIa15WveJJGw=
435439
github.com/mitchellh/copystructure v1.2.0/go.mod h1:qLl+cE2AmVv+CoeAwDPye/v+N2HKCj9FbZEVFJRxO9s=
436440
github.com/mitchellh/go-homedir v1.1.0 h1:lukF9ziXFxDFPkA1vsr5zpc1XuPDn/wFntq5mG+4E0Y=

x-pack/apm-server/sampling/eventstorage/pebble.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
"github.com/cockroachdb/pebble/v2"
1212
"github.com/cockroachdb/pebble/v2/bloom"
13+
"github.com/cockroachdb/pebble/v2/sstable"
1314

1415
"github.com/elastic/apm-server/internal/logs"
1516
"github.com/elastic/elastic-agent-libs/logp"
@@ -46,18 +47,18 @@ func OpenEventPebble(storageDir string, cacheSize uint64, logger *logp.Logger) (
4647
FormatMajorVersion: pebble.FormatColumnarBlocks,
4748
Logger: logger.Named(logs.Sampling),
4849
MemTableSize: 16 << 20,
49-
Levels: []pebble.LevelOptions{
50+
Levels: [7]pebble.LevelOptions{
5051
{
5152
BlockSize: 32 << 10, // the bigger the blocks, the better the compression and the smaller the index block
52-
Compression: func() pebble.Compression { return pebble.SnappyCompression },
53+
Compression: func() *sstable.CompressionProfile { return sstable.SnappyCompression },
5354
FilterPolicy: bloom.FilterPolicy(10),
5455
FilterType: pebble.TableFilter,
5556
},
5657
},
5758
Comparer: eventComparer(),
5859
Cache: cache,
59-
MaxConcurrentCompactions: func() int {
60-
return 2
60+
CompactionConcurrencyRange: func() (lower int, upper int) {
61+
return 1, 2
6162
}, // Better utilizes CPU on larger instances
6263
}
6364
return pebble.Open(filepath.Join(storageDir, "event"), opts)
@@ -71,17 +72,17 @@ func OpenDecisionPebble(storageDir string, cacheSize uint64, logger *logp.Logger
7172
FormatMajorVersion: pebble.FormatColumnarBlocks,
7273
Logger: logger.Named(logs.Sampling),
7374
MemTableSize: 2 << 20, // big memtables are slow to scan, and significantly slow the hot path
74-
Levels: []pebble.LevelOptions{
75+
Levels: [7]pebble.LevelOptions{
7576
{
7677
BlockSize: 2 << 10,
77-
Compression: func() pebble.Compression { return pebble.NoCompression },
78+
Compression: func() *sstable.CompressionProfile { return sstable.NoCompression },
7879
FilterPolicy: bloom.FilterPolicy(10),
7980
FilterType: pebble.TableFilter,
8081
},
8182
},
8283
Cache: cache,
83-
MaxConcurrentCompactions: func() int {
84-
return 2
84+
CompactionConcurrencyRange: func() (lower int, upper int) {
85+
return 1, 2
8586
}, // Better utilizes CPU on larger instances
8687
}
8788
return pebble.Open(filepath.Join(storageDir, "decision"), opts)

x-pack/apm-server/sampling/eventstorage/storage_manager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,8 @@ func (sm *StorageManager) RotatePartitions() error {
410410
return errors.Join(
411411
wrapNonNilErr("event db delete range error: %w", sm.eventDB.DeleteRange(lb, ub, pebble.NoSync)),
412412
wrapNonNilErr("decision db delete range error: %w", sm.decisionDB.DeleteRange(lb, ub, pebble.NoSync)),
413-
wrapNonNilErr("event db compact error: %w", sm.eventDB.Compact(lb, ub, false)),
414-
wrapNonNilErr("decision db compact error: %w", sm.decisionDB.Compact(lb, ub, false)),
413+
wrapNonNilErr("event db compact error: %w", sm.eventDB.Compact(context.Background(), lb, ub, false)),
414+
wrapNonNilErr("decision db compact error: %w", sm.decisionDB.Compact(context.Background(), lb, ub, false)),
415415
)
416416
}
417417

0 commit comments

Comments
 (0)