[Build] update eclipse formatter used by spotless (#135382)

We cannot directly declare the ecl and jdt core dependency but we can tweak the used
dependency by spotless in our precommit plugin.

Author: breskeby

build-conventions/src/main/java/org/elasticsearch/gradle/internal/conventions/precommit/FormattingPrecommitPlugin.java

@@ -52,6 +52,23 @@ public void apply(Project project) {
             // Spotless resolves required dependencies from project repositories, so we need maven central
             project.getRepositories().mavenCentral();
 
+            // we cannot update to a newer spotless plugin version yet but we want to use the latest eclipse formatter to be compatible
+            // with latest java versions
+            project.getConfigurations().matching(it -> it.getName().startsWith("spotless")).configureEach(conf -> {
+                project.getDependencies().constraints(constraints -> {
+                    constraints.add(conf.getName(), "org.eclipse.jdt:org.eclipse.jdt.core:3.42.0", dependencyConstraint -> {
+                        dependencyConstraint.because(
+                            "We want to use a recent version of the Eclipse formatter libraries to support latest Java"
+                        );
+                    });
+                    constraints.add(conf.getName(), "org.eclipse.jdt:ecj:3.42.0", dependencyConstraint -> {
+                        dependencyConstraint.because(
+                            "We want to use a recent version of the Eclipse formatter libraries to support latest Java"
+                        );
+                    });
+                });
+            });
+
             project.getExtensions().getByType(SpotlessExtension.class).java(java -> {
                 File elasticsearchWorkspace = Util.locateElasticsearchWorkspace(project.getGradle());
                 String importOrderPath = "build-conventions/elastic.importorder";
@@ -74,7 +91,7 @@ public void apply(Project project) {
                 // When running build benchmarks we alter the source in some scenarios.
                 // The gradle-profiler unfortunately does not generate compliant formatted
                 // sources so we ignore that altered file when running build benchmarks
-                if(Boolean.getBoolean("BUILD_PERFORMANCE_TEST") && project.getPath().equals(":server")) {
+                if (Boolean.getBoolean("BUILD_PERFORMANCE_TEST") && project.getPath().equals(":server")) {
                     java.targetExclude("src/main/java/org/elasticsearch/bootstrap/BootstrapInfo.java");
                 }
             });

gradle/verification-metadata.xml

@@ -3913,16 +3913,21 @@
             <sha256 value="97c566b120009c203a2fc8b291f4a9adbc171cf1ccb70f06f6b4e1828c00ce8e" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="org.eclipse.jdt" name="org.eclipse.jdt.core" version="3.35.0">
-         <artifact name="org.eclipse.jdt.core-3.35.0.jar">
-            <sha256 value="8f5bcb00355b271638b9d82a8cccd0e733225cb74c4a3f0f55a7b75d43ee442a" origin="Generated by Gradle"/>
+      <component group="org.eclipse.jdt" name="ecj" version="3.42.0">
+         <artifact name="ecj-3.42.0.jar">
+            <sha256 value="29f6d3918ee02db4400c103bc25dd90a22491c3a395867d9393070cb96a7dd29" origin="Generated by Gradle"/>
          </artifact>
       </component>
       <component group="org.eclipse.jdt" name="org.eclipse.jdt.core" version="3.38.0">
          <artifact name="org.eclipse.jdt.core-3.38.0.jar">
             <sha256 value="f0387e80ed4327d39f1f63da8773ee460af4edd78f7c2efecb4ba9bc0628bf60" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="org.eclipse.jdt" name="org.eclipse.jdt.core" version="3.42.0">
+         <artifact name="org.eclipse.jdt.core-3.42.0.jar">
+            <sha256 value="cac5d217e6df38900c1654f937d6af27ef9b433f59e8a9254b8c693e811517e3" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="org.eclipse.jetty" name="jetty-annotations" version="9.4.40.v20210413">
          <artifact name="jetty-annotations-9.4.40.v20210413.jar">
             <sha256 value="faccdc2113daf5ace9157cacd98751a41280fec94f584fd571b7fc26ff84742d" origin="Generated by Gradle"/>

server/src/main/java/org/elasticsearch/ingest/IngestService.java

@@ -916,6 +916,7 @@ private record IngestPipelinesExecutionResult(
             null,
             IndexDocFailureStoreStatus.NOT_APPLICABLE_OR_UNKNOWN
         );
+
         private static IngestPipelinesExecutionResult failAndStoreFor(String index, Exception e) {
             return new IngestPipelinesExecutionResult(false, true, e, index, IndexDocFailureStoreStatus.USED);
         }

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/azureaistudio/response/AzureAiStudioRerankResponseEntity.java

@@ -111,6 +111,7 @@ record RerankResultEntry(Float relevanceScore, Integer index, @Nullable ObjectPa
             PARSER.declareInt(constructorArg(), new ParseField("index"));
             PARSER.declareObject(optionalConstructorArg(), ObjectParser.PARSER::apply, new ParseField("document"));
         }
+
         public RankedDocsResults.RankedDoc toRankedDoc() {
             return new RankedDocsResults.RankedDoc(index, relevanceScore, document == null ? null : document.text);
         }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/response/HuggingFaceRerankResponseEntityTests.java

@@ -134,8 +134,8 @@ private void assertMissingFieldThrowsIllegalArgumentException(String responseJso
         assertThat(thrownException.getMessage(), is("Required [" + missingField + "]"));
     }
 
-    private void assertTopNLimit(
-        Integer topN, String responseJson, List<RankedDocsResultsTests.RerankExpectation> expectation) throws IOException {
+    private void assertTopNLimit(Integer topN, String responseJson, List<RankedDocsResultsTests.RerankExpectation> expectation)
+        throws IOException {
         when(REQUEST_MOCK.getTopN()).thenReturn(topN);
 
         RankedDocsResults parsedResults = HuggingFaceRerankResponseEntity.fromResponse(

x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManagerTests.java

@@ -907,19 +907,18 @@ public void testSetJobState_withHandler_onResponse_triggersHandlerNull() throws
 
     public void testSetJobState_withHandler_onFailure_triggersHandlerException() throws IOException {
         // Verifies that when updatePersistentTaskState reports a failure, the handler receives that exception
-        when(threadPool.schedule(any(Runnable.class), any(TimeValue.class), any(Executor.class)))
-            .thenAnswer(invocation -> {
-                Runnable r = invocation.getArgument(0);
-                r.run();
-                return mock(ThreadPool.Cancellable.class);
-            });
+        when(threadPool.schedule(any(Runnable.class), any(TimeValue.class), any(Executor.class))).thenAnswer(invocation -> {
+            Runnable r = invocation.getArgument(0);
+            r.run();
+            return mock(ThreadPool.Cancellable.class);
+        });
         AutodetectProcessManager manager = createSpyManager();
         JobTask jobTask = mock(JobTask.class);
         ResourceNotFoundException boom = new ResourceNotFoundException("boom");
         doAnswer(invocation -> {
             @SuppressWarnings("unchecked")
-            ActionListener<PersistentTasksCustomMetadata.PersistentTask<?>> listener =
-                (ActionListener<PersistentTasksCustomMetadata.PersistentTask<?>>) invocation.getArguments()[1];
+            ActionListener<PersistentTasksCustomMetadata.PersistentTask<?>> listener = (ActionListener<
+                PersistentTasksCustomMetadata.PersistentTask<?>>) invocation.getArguments()[1];
             listener.onFailure(boom);
             return null;
         }).when(jobTask).updatePersistentTaskState(any(), any());

x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/retention/MockWritableIndexExpander.java

@@ -30,10 +30,8 @@ public static WritableIndexExpander create(boolean stateIndexWritable) {
     }
 
     private static void mockWhenIndicesAreNotWritable(WritableIndexExpander writableIndexExpander) {
-        when(writableIndexExpander.getWritableIndices(anyString()))
-            .thenReturn(new ArrayList<>());
-        when(writableIndexExpander.getWritableIndices(ArgumentMatchers.<Collection<String>>any()))
-            .thenReturn(new ArrayList<>());
+        when(writableIndexExpander.getWritableIndices(anyString())).thenReturn(new ArrayList<>());
+        when(writableIndexExpander.getWritableIndices(ArgumentMatchers.<Collection<String>>any())).thenReturn(new ArrayList<>());
     }
 
     private static void mockWhenIndicesAreWritable(WritableIndexExpander writableIndexExpander) {

x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/expression/function/scalar/string/BinaryStringNumericProcessor.java

@@ -44,7 +44,7 @@ public enum BinaryStringNumericOperation implements BiFunction<String, Number, S
             if (i <= 0) {
                 return null;
             }
-            checkResultLength(s.length() * c.longValue()); // mul is safe: c's checked by doProcess() to be within Integer's range
+            checkResultLength(s.length() * c.longValue());// mul is safe: c's checked by doProcess() to be within Integer's range
             return s.repeat(i);
         });