Skip to content

Commit 270256a

Browse files
KDKHDkibanamachine
andauthored
[GenAi] Enable the Default LLM Setting feature flag by default <9.1 (#238986)
## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. Related: #238982 Enables the new Default LLM setting by default. The feature flag will be cleaned up in the future. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]>
1 parent a714532 commit 270256a

File tree

5 files changed

+22
-5
lines changed

5 files changed

+22
-5
lines changed

x-pack/platform/packages/shared/ai-assistant-default-llm-setting/src/components/default_ai_connector.tsx

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,13 @@ import { i18n } from '@kbn/i18n';
3333
import { NO_DEFAULT_CONNECTOR } from '../lib/constants';
3434
import { useDefaultAiConnectorSettingContext } from '../context/default_ai_connector_context';
3535

36+
/** Feature flag for the default AI connector setting */
3637
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED =
3738
'aiAssistant.defaultLlmSettingEnabled' as const;
3839

40+
/** The default value for the default AI connector setting */
41+
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE = true as const;
42+
3943
interface ConnectorData {
4044
connectors?: Array<{
4145
id: string;
@@ -272,7 +276,12 @@ export const DefaultAIConnector: React.FC<Props> = ({ connectors, settings }) =>
272276
);
273277
}, [elasticManagedLlmExists, application, docLinks]);
274278

275-
if (!featureFlags.getBooleanValue(AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED, false)) {
279+
if (
280+
!featureFlags.getBooleanValue(
281+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
282+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
283+
)
284+
) {
276285
return null;
277286
}
278287

x-pack/solutions/security/plugins/security_solution/common/constants.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,9 @@ export const DEFAULT_AI_CONNECTOR = 'securitySolution:defaultAIConnector' as con
178178
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED =
179179
'aiAssistant.defaultLlmSettingEnabled' as const;
180180

181+
/** The default value for the default AI connector setting */
182+
export const AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE = true as const;
183+
181184
/** This Kibana Advanced Setting allows users to enable/disable querying cold and frozen data tiers in analyzer */
182185
export const EXCLUDE_COLD_AND_FROZEN_TIERS_IN_ANALYZER =
183186
'securitySolution:excludeColdAndFrozenTiersInAnalyzer' as const;

x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { getDefaultConnector } from '@kbn/elastic-assistant/impl/assistant/helpe
1313
import {
1414
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
1515
DEFAULT_AI_CONNECTOR,
16+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE,
1617
} from '../../../common/constants';
1718

1819
jest.mock('../lib/kibana');
@@ -96,7 +97,7 @@ describe('useDefaultAIConnectorId', () => {
9697

9798
expect(mockFeatureFlags.getBooleanValue).toHaveBeenCalledWith(
9899
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
99-
false
100+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
100101
);
101102
});
102103

x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { getDefaultConnector } from '@kbn/elastic-assistant/impl/assistant/helpe
99
import { useMemo } from 'react';
1010
import {
1111
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
12+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE,
1213
DEFAULT_AI_CONNECTOR,
1314
} from '../../../common/constants';
1415
import { useAIConnectors } from './use_ai_connectors';
@@ -21,7 +22,7 @@ export const useDefaultAIConnectorId = () => {
2122
const legacyDefaultConnectorId = uiSettings.get<string>(DEFAULT_AI_CONNECTOR);
2223
const useNewDefaultConnector = featureFlags.getBooleanValue(
2324
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
24-
false
25+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
2526
);
2627
const newDefaultConnectorId = getDefaultConnector(connectors, settings)?.id;
2728

x-pack/solutions/security/plugins/security_solution/public/flyout/ai_for_soc/components/connector_missing_callout.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ import { EuiCallOut, EuiLink } from '@elastic/eui';
1010
import { useNavigateTo } from '@kbn/security-solution-navigation';
1111
import { i18n } from '@kbn/i18n';
1212
import { useKibana } from '../../../common/lib/kibana';
13-
import { AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED } from '../../../../common/constants';
13+
import {
14+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
15+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE,
16+
} from '../../../../common/constants';
1417

1518
const MISSING_CONNECTOR = i18n.translate('xpack.securitySolution.alertSummary.missingConnector', {
1619
defaultMessage: 'Missing connector',
@@ -56,7 +59,7 @@ export const ConnectorMissingCallout = memo(
5659
const { featureFlags } = useKibana().services;
5760
const useNewDefaultConnector = featureFlags.getBooleanValue(
5861
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED,
59-
false
62+
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE
6063
);
6164
const { navigateTo } = useNavigateTo();
6265
const goToKibanaSettings = useCallback(

0 commit comments

Comments
 (0)