Fix regression where we did not report failure

erikjohnston · erikjohnston · commit 603ebedf24e9 · 2025-11-26T11:41:45.000Z
diff --git a/scripts-dev/check_schema_delta.py b/scripts-dev/check_schema_delta.py
@@ -137,6 +137,9 @@ def main(force_colors: bool) -> None:
             color=force_colors,
         )
 
+        # Mark this run as not successful, but continue so that we report *all*
+        # errors.
+        return_code = 1
     else:
         click.secho(
             f"All deltas are in the correct folder: {current_schema_version}!",

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,9 @@ def main(force_colors: bool) -> None:`
`137`	`137`	`color=force_colors,`
`138`	`138`	`)`
`139`	`139`
	`140`	`+ # Mark this run as not successful, but continue so that we report all`
	`141`	`+ # errors.`
	`142`	`+ return_code = 1`
`140`	`143`	`else:`
`141`	`144`	`click.secho(`
`142`	`145`	`f"All deltas are in the correct folder: {current_schema_version}!",`