Commands: improved finding the root mix.exs file

Author: azizk

commands/mix_test.py

@@ -451,7 +451,9 @@ def reverse_find_json_path(window, json_file_path):
   paths = [window.active_view().file_name()] + window.folders()
   root_dir = next((reverse_find_root_folder(p) for p in paths if p), None)
 
-  root_dir or print_status_msg(COULDNT_FIND_MIX_EXS)
+  if not root_dir:
+    sublime.message_dialog(COULDNT_FIND_MIX_EXS)
+    print_status_msg(COULDNT_FIND_MIX_EXS)
 
   return root_dir and path.join(root_dir, json_file_path) or None
 
@@ -467,13 +469,14 @@ def merge_mix_settings_and_params(window, params):
     return
 
   root_dir = path.dirname(mix_settings_path)
-  build_dir = path.join(root_dir, '_build')
 
   if 'abs_file_path' in params:
     params.setdefault('file_path', path.relpath(params['abs_file_path'], root_dir))
     del params['abs_file_path']
 
-  save_json_file(path.join(build_dir, FILE_NAMES.REPEAT_JSON), params)
+  build_dir = Path(root_dir) / '_build'
+  build_dir.exists() or build_dir.mkdir()
+  save_json_file(str(build_dir / FILE_NAMES.REPEAT_JSON), params)
 
   mix_params = load_json_file(mix_settings_path)
   mix_params = remove_help_info(mix_params)

commands/utils.py

@@ -14,8 +14,8 @@
 MIX_RESULT_FILE_REGEX = r'(\S+?[/\\]\S+?\.[a-zA-Z]+):(\d+)(?::(\d+))?'
 
 COULDNT_FIND_MIX_EXS = \
-  'Error: could not find a mix.exs file and the _build/ directory!\n' + \
-    'Make sure that you are in a mix project and that `mix \'do\' deps.get, compile` has been run.'
+  'Error: could not find a mix.exs file!\n' + \
+    'Make sure that you are in a mix project.'
 
 def print_status_msg(msg):
   print(PRINT_PREFIX, msg)
@@ -53,9 +53,17 @@ def reverse_find_root_folder(bottom_path):
   parent_path = bottom_path.parent if bottom_path.is_file() else bottom_path
 
   while True:
-    if all((parent_path / p).exists() for p in ['mix.exs', '_build']):
+    # We have to check for the root mix.exs, ignoring possible sub-app mix files.
+    if (parent_path / 'mix.exs').exists() \
+       and (
+         (parent_path / 'mix.lock').exists()
+         or (parent_path / '_build').exists()
+         or parent_path.name != 'apps' and not (parent_path.parent / 'mix.exs').exists()
+       ):
       return str(parent_path)
+
     old_path, parent_path = parent_path, parent_path.parent
+
     if old_path == parent_path:
       break